fix(bridge): live quotes and clear fee-limit feedback - #52
Conversation
Debounce unsigned quotes without locking amount or route edits. Cancel stale requests and show verified fee-limit diagnostics. Keep both 5% limits and all wallet approvals/deposits explicit. Refs #50
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (18)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe bridge now refreshes quotes after valid edits, cancels stale requests, validates fee-limit diagnostics, and displays quote loading, expiry, errors, and rejection details. ChangesBridge quote flow
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant User
participant BridgeDialog
participant useBridge
participant QuoteSession
participant Relay
User->>BridgeDialog: Edit amount or route
BridgeDialog->>useBridge: Update quote request
useBridge->>QuoteSession: Schedule quote
QuoteSession->>Relay: Request quote after 700 ms
Relay-->>useBridge: Return quote or rejection diagnostics
useBridge-->>BridgeDialog: Update quote, loading, or error state
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The bridge keeps inputs editable while refreshing quotes and correctly replaces quotes after valid route changes. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 30.43% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 23 functions across 16 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Separate fees from gas and keep exact limits readable without changing bridge safety checks.
Sync Kevin's Arc launch support and shared chain registry before merging the bridge quote UX.
The registry guard uses POSIX path allowlists and line-end anchored comment removal. Normalize path separators and CRLF so Windows checkouts enforce the same guard as Linux.
Why
Follow-up to the already-merged #50. Getting a quote should not require another click after every amount edit, and the 5% warning should explain the actual cost.
Changes
Verification
No dependency, contract, fee-policy or unrelated lockfile changes.
Summary by CodeRabbit
New Features
Bug Fixes