updated footer with better ui/ux#295
Open
ArshiBansal wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for github-spy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📝 WalkthroughWalkthroughThe Footer component was redesigned from a compact layout to a multi-section structure. Imports were expanded for additional icons. The JSX now includes a top section with a branded GitHub link, descriptive text, quick navigation links, and a social connect button with accessibility attributes, followed by a divider and bottom section with copyright and "made with" text. The component signature and export remain unchanged. ChangesFooter Component Multi-Section Redesign
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/Footer.tsx (1)
13-13: ⚡ Quick winExtract duplicated GitHub URL to a constant.
The GitHub repository URL
https://github.com/GitMetricsLab/github_trackeris hardcoded in two locations (brand link and social link). Extracting it to a constant will prevent inconsistencies and make future updates easier.♻️ Proposed refactor
import { FaGithub, FaEnvelope, FaInfoCircle, FaHeart } from 'react-icons/fa'; import { Link } from 'react-router-dom'; +const GITHUB_REPO_URL = "https://github.com/GitMetricsLab/github_tracker"; + function Footer() { return ( <footer className="bg-gradient-to-br from-white to-gray-50 dark:from-gray-900 dark:to-gray-950 border-t border-gray-200/70 dark:border-gray-800/70 text-gray-700 dark:text-gray-300 transition-colors duration-300"> <div className="max-w-7xl mx-auto px-6 py-10"> {/* Top Section */} <div className="grid grid-cols-1 md:grid-cols-3 gap-8 items-start"> {/* Brand Section */} <div className="space-y-3"> <a - href="https://github.com/GitMetricsLab/github_tracker" + href={GITHUB_REPO_URL} target="_blank" rel="noopener noreferrer"{/* Social Section */} <div className="space-y-3 md:text-right"> <h3 className="text-sm font-semibold uppercase tracking-wider text-gray-900 dark:text-white"> Connect </h3> <div className="flex md:justify-end"> <a - href="https://github.com/GitMetricsLab/github_tracker" + href={GITHUB_REPO_URL} target="_blank" rel="noopener noreferrer"Also applies to: 63-63
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Footer.tsx` at line 13, The hardcoded GitHub URL appears twice in the Footer component; create a single exported/locally-scoped constant (e.g., GITHUB_URL) at the top of src/components/Footer.tsx and replace both occurrences (the brand link and the social link JSX) with that constant (use GITHUB_URL in the href props) so updates remain consistent and reduce duplication.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/Footer.tsx`:
- Line 13: The hardcoded GitHub URL appears twice in the Footer component;
create a single exported/locally-scoped constant (e.g., GITHUB_URL) at the top
of src/components/Footer.tsx and replace both occurrences (the brand link and
the social link JSX) with that constant (use GITHUB_URL in the href props) so
updates remain consistent and reduce duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Description
The current footer could use a design refresh to make it more attractive, modern, and professional. A well-crafted footer not only improves the overall look of the site but also ensures that important links and information are easy to find, enhancing the overall user experience.
How Has This Been Tested?
Through Comparing initial deployed link with updated locally hosted one
Screenshots (if applicable)
Type of Change
Summary by CodeRabbit