fix: resolve failing backend tests for auth routes and user model (#278)#286
fix: resolve failing backend tests for auth routes and user model (#278)#286JayRathore10 wants to merge 1 commit into
Conversation
✅ Deploy Preview for github-spy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis PR refactors the User model's password middleware from callback-based ( ChangesUser Password Middleware Modernization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thank you @JayRathore10 for your contribution. Please make sure your PR follows https://github.com/GitMetricsLab/github_tracker/blob/main/CONTRIBUTING.md#-pull-request-guidelines
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 46: The listed auth/session libraries (bcryptjs, passport,
passport-local, express-session) are runtime backend deps but currently live in
devDependencies; edit package.json to remove these four entries from
devDependencies and add them under dependencies with their existing version
strings, then run your package manager (npm install or yarn) to update
package-lock.json/yarn.lock so production installs include them; verify no other
code references remain that assume dev-only usage and that the server starts
correctly.
In `@spec/auth.routes.spec.cjs`:
- Line 39: The test suite currently calls
mongoose.connect('mongodb://127.0.0.1:27017/github_tracker_test') which shares a
fixed database with other specs and causes teardown races when dropDatabase() is
called; change the connect call so this suite uses an isolated database name
(e.g., append a unique suffix like process.pid, Date.now(), a UUID, or the test
worker id) so that mongoose.connect(...) creates a per-suite DB and
dropDatabase() only affects that DB; update any teardown that references
dropDatabase() to operate on the same unique DB name (referencing the
mongoose.connect call and the existing dropDatabase() call to ensure they use
the same derived name).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 851efbc1-4313-46a5-a04d-fba04346b05c
📒 Files selected for processing (4)
backend/models/User.jspackage.jsonspec/auth.routes.spec.cjsspec/user.model.spec.cjs
| "@vitejs/plugin-react-swc": "^3.5.0", | ||
| "autoprefixer": "^10.4.20", | ||
| "bcryptjs": "^3.0.2", | ||
| "bcryptjs": "^3.0.3", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if bcryptjs, passport, passport-local, and express-session are used in backend code
echo "=== Checking bcryptjs usage ==="
rg -n --type=js --type=cjs "require\(['\"]bcryptjs['\"]\)|from ['\"]bcryptjs['\"]" -g '!node_modules' -g '!spec' -g '!test'
echo -e "\n=== Checking passport usage ==="
rg -n --type=js --type=cjs "require\(['\"]passport['\"]\)|from ['\"]passport['\"]" -g '!node_modules' -g '!spec' -g '!test'
echo -e "\n=== Checking passport-local usage ==="
rg -n --type=js --type=cjs "require\(['\"]passport-local['\"]\)|from ['\"]passport-local['\"]" -g '!node_modules' -g '!spec' -g '!test'
echo -e "\n=== Checking express-session usage ==="
rg -n --type=js --type=cjs "require\(['\"]express-session['\"]\)|from ['\"]express-session['\"]" -g '!node_modules' -g '!spec' -g '!test'Repository: GitMetricsLab/github_tracker
Length of output: 346
🏁 Script executed:
#!/bin/bash
# First, check the structure of the repo
echo "=== Repository Structure ==="
ls -la
echo ""
# Check if backend directory exists
echo "=== Looking for backend/models/User.js ==="
find . -name "User.js" -o -name "user.js" 2>/dev/null | head -20
echo ""
# List all JS/TS files to understand the codebase structure
echo "=== File types in repo ==="
fd '\.(js|ts|jsx|tsx|cjs|mjs)$' --type f | grep -v node_modules | head -30
echo ""
# Check current package.json
echo "=== Checking package.json devDependencies section ==="
cat package.json | grep -A 30 '"devDependencies"'Repository: GitMetricsLab/github_tracker
Length of output: 3473
🏁 Script executed:
#!/bin/bash
echo "=== backend/models/User.js ==="
cat -n backend/models/User.js
echo -e "\n=== backend/config/passportConfig.js ==="
cat -n backend/config/passportConfig.js
echo -e "\n=== backend/routes/auth.js ==="
cat -n backend/routes/auth.js
echo -e "\n=== backend/server.js ==="
cat -n backend/server.jsRepository: GitMetricsLab/github_tracker
Length of output: 5573
Move backend runtime dependencies from devDependencies to dependencies.
bcryptjs, passport, passport-local, and express-session are used in production backend code (password hashing, authentication configuration, session management) but are currently in devDependencies. When deploying with npm install --production, these packages will be excluded, causing the backend to fail at runtime with missing module errors.
Move these four packages to dependencies:
Proposed fix
"dependencies": {
"react-router-dom": "^6.28.0",
- "tailwindcss": "^3.4.14"
+ "tailwindcss": "^3.4.14",
+ "bcryptjs": "^3.0.3",
+ "express-session": "^1.18.2",
+ "passport": "^0.7.0",
+ "passport-local": "^1.0.0"
},
"devDependencies": {
"`@eslint/js`": "^9.13.0",
"`@types/jasmine`": "^5.1.8",
"`@types/node`": "^22.10.1",
"`@types/react`": "^18.3.23",
"`@types/react-dom`": "^18.3.7",
"`@types/react-redux`": "^7.1.34",
"`@types/react-router-dom`": "^5.3.3",
"`@vitejs/plugin-react-swc`": "^3.5.0",
"autoprefixer": "^10.4.20",
- "bcryptjs": "^3.0.3",
"eslint": "^9.13.0",
"eslint-plugin-react": "^7.37.2",
"eslint-plugin-react-hooks": "^5.0.0",
"eslint-plugin-react-refresh": "^0.4.14",
- "express-session": "^1.18.2",
"globals": "^15.11.0",
"jasmine": "^5.9.0",
- "passport": "^0.7.0",
- "passport-local": "^1.0.0",
"supertest": "^7.1.4",
"vite": "^5.4.10"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 46, The listed auth/session libraries (bcryptjs,
passport, passport-local, express-session) are runtime backend deps but
currently live in devDependencies; edit package.json to remove these four
entries from devDependencies and add them under dependencies with their existing
version strings, then run your package manager (npm install or yarn) to update
package-lock.json/yarn.lock so production installs include them; verify no other
code references remain that assume dev-only usage and that the server starts
correctly.
| useNewUrlParser: true, | ||
| useUnifiedTopology: true, | ||
| }); | ||
| await mongoose.connect('mongodb://127.0.0.1:27017/github_tracker_test'); |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify shared DB URI and destructive teardown usage across specs.
rg -n "mongodb://127\.0\.0\.1:27017/github_tracker_test"
rg -n "dropDatabase\s*\(" specRepository: GitMetricsLab/github_tracker
Length of output: 441
Isolate this suite's test database to prevent cross-spec teardown races.
Line 39 connects to a fixed DB (github_tracker_test), and Line 45 calls dropDatabase(). spec/user.model.spec.cjs uses the same URI and also drops the DB, so concurrent spec execution can wipe state mid-test and create flakes.
Suggested change
+const TEST_DB = 'github_tracker_test_auth_routes';
beforeAll(async () => {
- await mongoose.connect('mongodb://127.0.0.1:27017/github_tracker_test');
+ await mongoose.connect(`mongodb://127.0.0.1:27017/${TEST_DB}`);
app = createTestApp();
});🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@spec/auth.routes.spec.cjs` at line 39, The test suite currently calls
mongoose.connect('mongodb://127.0.0.1:27017/github_tracker_test') which shares a
fixed database with other specs and causes teardown races when dropDatabase() is
called; change the connect call so this suite uses an isolated database name
(e.g., append a unique suffix like process.pid, Date.now(), a UUID, or the test
worker id) so that mongoose.connect(...) creates a per-suite DB and
dropDatabase() only affects that DB; update any teardown that references
dropDatabase() to operate on the same unique DB name (referencing the
mongoose.connect call and the existing dropDatabase() call to ensure they use
the same derived name).
|
@JayRathore10 - pls resolve conflicts |
2 participants
🔧 Fix: Resolve failing backend test suites for Auth Routes and User Model (#278)
📌 Overview
This PR fixes multiple failing backend test cases related to Auth Routes and the User Model. The root cause was incorrect usage of Mongoose middleware, which caused errors during user creation and authentication flows.
🐛 Issues Identified
TypeError: next is not a functionin User model pre-save hook500instead of201✅ Fixes Implemented
nextusage)comparePasswordmethod for accurate authentication🧪 Test Results
📂 Files Modified
backend/models/User.jsspec/user.model.spec.cjsspec/auth.routes.spec.cjs🏷️ Open Source Context
This PR is submitted as part of GSSoC (GirlScript Summer of Code) contribution.
👤 Contributor Profile
GSSoC Profile: https://gssoc.girlscript.org/profile/e47b2f4a-f3e9-4cb4-97b5-ddd8cb15a1e9
🚀 Impact
This fix ensures:
Screenshot of
npm run test📎 Notes
No breaking changes introduced. Existing functionality remains intact while fixing test stability and backend logic.
Summary by CodeRabbit
Dependencies
Tests