CMake build updated to work with Windows VS2019 (vc-142) - #79
Closed
dennis2society wants to merge 6 commits into
Closed
CMake build updated to work with Windows VS2019 (vc-142)#79dennis2society wants to merge 6 commits into
dennis2society wants to merge 6 commits into
Conversation
…ou choose in CMake Gui - added forward declaration already PR'd here https://github.com/GillesDebunne/libQGLViewer/pull/71/files to fix the Qt6 build on Windows (this was not a problem with Qt5...)
dennis2society
changed the title
lrineau
reviewed
Oct 3, 2023
… manual distinction
Author
|
Superseded by PR #80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CMakeLists.txt to allow an easy CMake configuration of the project in Windows.
The main challenge was to pass
NOMINMAXto the VS projects to properly use std::min/max instead of the macros defined in minwindef.h and to ignore the VC warning 4996.Additionally I had to add two changes suggested here:
Pull request by @bjornplitz #71
Funnily this was only necessary for building with Qt6 on Windows.
On Windows it is now only necessary to open the libQGLViewer repo folder with CMake-Gui and set either Qt5 or Qt6 dir. Qt6 also requires setting the Qt6GuiTools cmake folder.
The Linux build can now be done like this:
This will build everything inside the build folder.