Skip to content

Free Learning: Fixed the issue of Non-Parameterised Input#59

Open
ali-ichk wants to merge 2 commits into
GibbonEdu:mainfrom
ali-ichk:Free-Learning---Parameterise-sql-variables
Open

Free Learning: Fixed the issue of Non-Parameterised Input#59
ali-ichk wants to merge 2 commits into
GibbonEdu:mainfrom
ali-ichk:Free-Learning---Parameterise-sql-variables

Conversation

@ali-ichk

Copy link
Copy Markdown
Contributor

Fixed the issue of Non-Parameterised Input
#58

@rossdotparker

Copy link
Copy Markdown
Member

Thanks @ali-ichk!

@SKuipers are you able to confirm for me that this is a safe way for the student ID list to be handled? Thanks!

@SKuipers

Copy link
Copy Markdown
Member

@rossdotparker Thanks for checking to confirm.

@ali-ichk While the variables have been sanitized, they have not necessarily been added as parameters. For best practice, they need to be added to the data array, and then used as a parameter in the SQL eg IN (:studentIDList)

@ali-ichk

Copy link
Copy Markdown
Contributor Author

@SKuipers thanks for the comments. I have made some changes based on your comments. Thanks. Happy Reviewing!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants