Skip to content

[CHANGE]: extract and centralize exception handling in update manager - #361

Merged
Geuthur merged 1 commit into
masterfrom
optimize-update-manager
Oct 11, 2026
Merged

Geuthur merged 1 commit into
masterfrom
optimize-update-manager

Conversation

@Geuthur

@Geuthur Geuthur commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Description

Changed

  • extract and centralize exception handling in update manager

Type of Changes

Please select the type of changes made in this pull request:

  • Bug Fix (non-breaking change which fixes an Issue)
  • New Feature (non-breaking change)
  • Other (please specify):

Checklist

Please ensure the following before submitting your pull request:

  • I have read the contributing guidelines.
  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • All new and existing tests passed.

@Geuthur
Geuthur merged commit 0b7281a into master Oct 11, 2026
36 checks passed
@Geuthur
Geuthur deleted the optimize-update-manager branch October 11, 2026 20:43
@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
ledger/models/helpers/update_manager.py 91.31% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   77.39%   77.75%   +0.37%     
==========================================
  Files          41       41              
  Lines        3586     3568      -18     
  Branches      365      365              
==========================================
- Hits         2775     2774       -1     
+ Misses        670      654      -16     
+ Partials      141      140       -1     
Files with missing lines Coverage Δ
ledger/models/helpers/update_manager.py 91.28% <91.31%> (+9.24%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant