Add APIHelper.mapValuesToQueryDictionary query-item helper#61
Merged
Conversation
Maps [String: Any?] to [String: String]?, dropping nil-valued keys and comma-joining collections. Used by the chat OpenAPI Swift generator so absent query params are omitted from the URL instead of serialized as "<null>". Existing mapValuesToQueryItems overloads are unchanged.
martinmitrevski
approved these changes
Jul 9, 2026
|
Copilot stopped work on behalf of
martinmitrevski due to an error
July 9, 2026 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
🎯 Goal
Generated Swift endpoints serialized nil query params as the literal string
<null>(e.g.?limit=<null>) instead of omitting them from the URL.📝 Summary
APIHelper.mapValuesToQueryDictionary(_ source: [String: Any?]) -> [String: String]?— drops nil-valued keys and comma-joins collection values.Bool→"true"/"false",[String]→ CSV, empty/all-nil →nil.🛠 Implementation
The chat OpenAPI Swift generator (GetStream/chat#14602) wraps generated
queryItemsdicts in this helper, passing scalars and[String]raw.[String: Any?](not[String: Any]) preserves optionality so nil detection works viafilter { $0.value != nil }; the[String: String]?return type conforms toEncodable & SendableforEndpoint.queryItems. The existingmapValuesToQueryItemsoverloads are left untouched.🎨 Showcase
N/A
🧪 Manual Testing Notes
N/A
☑️ Contributor Checklist
docs-contentrepo