Repository navigation
ci(repo): lower pana thresholds for cross_file 0.4.0 - #204
Conversation
cross_file 0.4.0 is a breaking federated rewrite that depends on Flutter, so stream_core (pure Dart) and stream_thumbnail cannot adopt it. Pana now deducts 10 points from both for an outdated dependency. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Package score thresholds .github/workflows/pana.yml |
The workflow lowers the minimum Pana score for stream_core from 125 to 120 and for stream_thumbnail from 150 to 140. It updates both explanatory comments. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Suggested reviewers: renefloor
Merge Risk: 
Minimal · up to e7e4e
-
No merge-blocking risk was identified in the threshold-only workflow update.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description explains the cause, affected packages, score changes, compatibility constraint, and local verification results. It does not include the template fields for Linear, GitHub Issue, CLA confirmations, or screenshots, but the core change and testing information are complete.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 71.46% 71.46%
=======================================
Files 215 215
Lines 8884 8884
=======================================
Hits 6349 6349
Misses 2535 2535 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The pana workflow is red on main for
stream_core(120 < 125) andstream_thumbnail(140 < 150).cross_file0.4.0 shipped, and our^0.3.4+2constraint excludes it, so pana deducts the 10 "dependencies supported in the latest version" points from both packages. 0.4.0 is a breaking federated rewrite (removesXFile(path),.path,mimeType,fromData; makesnameasync) and adds a Flutter dependency, sostream_core, which is pure Dart, can't adopt it.This lowers both thresholds by 10 and corrects the comments to list the actual deductions.
Verified by running
pana0.23.19 locally on both packages: 120/160 and 140/160, withcross_filethe outdated dependency in each.🤖 Generated with Claude Code
Summary by CodeRabbit