Skip to content

ci(repo): lower pana thresholds for cross_file 0.4.0 - #204

Merged
xsahil03x merged 1 commit into
mainfrom
ci/pana-cross-file-thresholds
Oct 27, 2026
Merged

xsahil03x merged 1 commit into
mainfrom
ci/pana-cross-file-thresholds

Conversation

@xsahil03x

@xsahil03x xsahil03x commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

The pana workflow is red on main for stream_core (120 < 125) and stream_thumbnail (140 < 150).

cross_file 0.4.0 shipped, and our ^0.3.4+2 constraint excludes it, so pana deducts the 10 "dependencies supported in the latest version" points from both packages. 0.4.0 is a breaking federated rewrite (removes XFile(path), .path, mimeType, fromData; makes name async) and adds a Flutter dependency, so stream_core, which is pure Dart, can't adopt it.

This lowers both thresholds by 10 and corrects the comments to list the actual deductions.

Verified by running pana 0.23.19 locally on both packages: 120/160 and 140/160, with cross_file the outdated dependency in each.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated automated quality-check thresholds for two components. The minimum acceptable scores are now 120 and 140, down from 125 and 150, respectively. These changes affect the checks applied during project maintenance and do not introduce changes to app features or behavior.

cross_file 0.4.0 is a breaking federated rewrite that depends on Flutter,
so stream_core (pure Dart) and stream_thumbnail cannot adopt it. Pana now
deducts 10 points from both for an outdated dependency.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@xsahil03x
xsahil03x requested a review from a team as a code owner October 27, 2026 14:11
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 180b90d8-612b-4479-b751-3b0c99e86881
Commits

Reviewing files that changed from the base of the PR and between 958a8d3 and e7e4e6e.

Files selected for processing: 1
  • .github/workflows/pana.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Pana workflow lowers the minimum scores for stream_core and stream_thumbnail. It also updates the comments that describe score deductions.

Changes: Pana score thresholds

Layer / File(s) Summary
Package score thresholds
.github/workflows/pana.yml
The workflow lowers the minimum Pana score for stream_core from 125 to 120 and for stream_thumbnail from 150 to 140. It updates both explanatory comments.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: renefloor

Merge Risk: Minimal · up to e7e4e

No merge-blocking risk was identified in the threshold-only workflow update.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: lowering Pana thresholds for the cross_file 0.4.0 compatibility issue.
Description check Passed The description explains the cause, affected packages, score changes, compatibility constraint, and local verification results. It does not include the template fields for Linear, GitHub Issue, CLA co…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the cause, affected packages, score changes, compatibility constraint, and local verification results. It does not include the template fields for Linear, GitHub Issue, CLA confirmations, or screenshots, but the core change and testing information are complete.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@xsahil03x
xsahil03x enabled auto-merge (squash) October 27, 2026 14:13
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.46%. Comparing base (958a8d3) to head (e7e4e6e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   71.46%   71.46%           
=======================================
  Files         215      215           
  Lines        8884     8884           
=======================================
  Hits         6349     6349           
  Misses       2535     2535           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x
xsahil03x disabled auto-merge October 27, 2026 14:29
@xsahil03x
xsahil03x merged commit 2e9beec into main Oct 27, 2026
18 checks passed
@xsahil03x
xsahil03x deleted the ci/pana-cross-file-thresholds branch October 27, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants