Skip to content

feat(profiles): skip the apply confirmation when the profile matches current routing #1683

Description

@barbatdev

Before submitting

  • I searched open and closed issues and did not find a request for this feature.
  • I reviewed this request and removed credentials, tokens, private paths, hostnames, and other sensitive data.

Problem or opportunity

Since PR #1384, every global profile apply asks for confirmation, including the case where the profile's agent routes already match the current global routing. That apply would change nothing, so the dialog is pure friction for an operator re-selecting the active profile or verifying state, and it trains users to approve the dialog without reading it, which weakens the guard on the destructive cases.

Proposed outcome

When the effective routing diff is empty (no replaced, cleared, or added agent routes, and no orchestrator change), applying should proceed without the confirmation dialog, or with a non-modal informational notice ("profile already active"), depending on what the maintainers prefer. The destructive confirmations introduced by #1349 and PR #1384 stay exactly as they are.

Alternatives considered

Keeping the confirm on no-op applies (current behavior) with the "its agent routes already match the current global routing" wording; it is safe but adds friction in the only non-destructive case.

Additional context

Identified during review of PR #1384 as a friction refinement. The dialog already computes the empty-diff case (extensions/gentle-ai.ts, populated-apply branch). Related: #1349, #1384.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions