Dev #18
Open
Dev #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thomas
I refactored, mavenized, cleaned up this project. Now libraries are mostly online as usual with maven. It needs the atk library that you received a pull request for. The only library that i did'nt find online is the samtools 1.107.
I think we have a working version on dev branch.
I suggest we merge back as this seems to all work OK and it's a big step forward from where it was.
The maven version is now 23.0.0, so it's above the last available previous version which had an unusual version number, 2250 or so.
The tests I did are very limited because I have no clue how the GUI works and what I'm supposed to see. I tested with the 3 demo sequences. It does show something, I can zoom in and out and it does not crash or throw ugly stuff.