Remove redundant net481 TargetFramework condition in Workspace SDK#188
Open
alafleur-genetec wants to merge 1 commit into
Open
Remove redundant net481 TargetFramework condition in Workspace SDK#188alafleur-genetec wants to merge 1 commit into
alafleur-genetec wants to merge 1 commit into
Conversation
… SDK samples The Workspace SDK sample projects target only .NET Framework 4.8.1: they define just Debug/Release, have no _NET8 configuration, and carry no net8.0-windows reference group. The "'$(TargetFramework)' == 'net481'" condition on the SDK reference ItemGroup was therefore always true and gated nothing, a leftover from the multi-targeting Platform SDK template. Make those reference groups unconditional. No change to build output.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Workspace SDK sample project files by removing a redundant ItemGroup condition that gated SDK assembly references on net481, even though these projects already target net481 only.
Changes:
- Removed
Condition="'$(TargetFramework)' == 'net481'"from theItemGroupthat containsGenetec.Sdk*references across multiple Workspace SDK sample.csprojfiles. - Left project targeting unchanged (
<TargetFrameworks>net481</TargetFrameworks>remains), making the condition unnecessary.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Samples/Workspace SDK/TimelineProviderSample/TimelineProviderSample.csproj | Makes the SDK reference ItemGroup unconditional (condition was redundant for net481-only targeting). |
| Samples/Workspace SDK/TileWidgetSample/TileWidgetSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/TileViewSample/TileViewSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/TilePropertiesSample/TilePropertiesSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/TaskSample/TaskSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/PageTaskSample/PageTaskSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/OptionsExtensionSample/OptionsExtensionSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/ImageExtractorSample/ImageExtractorSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/EventExtenderSample/EventExtenderSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/DashboardWidgetSample/DashboardWidgetSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/CredentialReaderSample/CredentialReaderSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/ControlsSample/ControlsSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/ContextualActionSample/ContextualActionSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/ConfigPageSample/ConfigPageSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/CommandManagerSample/CommandManagerSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/CardholderFieldsExtractorSample/CardholderFieldsExtractorSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/CardholderCredentialReaderSample/CardholderCredentialReaderSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/BadgePrinterSample/BadgePrinterSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
| Samples/Workspace SDK/BackgroundProcessSample/BackgroundProcessSample.csproj | Removes redundant net481 ItemGroup condition around SDK references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.