Use singular TargetFramework for Platform SDK sample configura…#187
Open
alafleur-genetec wants to merge 1 commit into
Open
Use singular TargetFramework for Platform SDK sample configura…#187alafleur-genetec wants to merge 1 commit into
alafleur-genetec wants to merge 1 commit into
Conversation
…tions Replace the multi-targeting <TargetFrameworks> form with a single-target <TargetFramework> conditioned on $(Configuration), so each build configuration maps to exactly one framework (Debug/Release build net481, Debug_NET8/Release_NET8 build net8.0-windows). Conditioning a cross-targeting <TargetFrameworks> on $(Configuration) made Visual Studio treat the projects as multi-targeting and produced build errors when switching configurations; a single-target <TargetFramework> is re-evaluated cleanly per configuration. Update the diagnostic message and the root and Platform SDK README snippets to match.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the Platform SDK sample projects’ framework selection by switching from conditional TargetFrameworks (multi-targeting) to a single conditional TargetFramework (configuration-based single targeting), and updates related build output messages and documentation.
Changes:
- Replace
TargetFrameworkswith configuration-conditionedTargetFrameworkacross Platform SDK sample.csprojfiles. - Update build-time diagnostic messages to display
$(TargetFramework)(singular) instead of$(TargetFrameworks). - Fix copyright symbol encoding (
�→©) and update README snippets to match the new project configuration.
Reviewed changes
Copilot reviewed 70 out of 70 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Samples/Platform SDK/VisitorManagerSample/VisitorManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/VideoUnitSample/VideoUnitSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/VideoFileQuerySample/VideoFileQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/VideoEventQuerySample/VideoEventQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/UserTaskSample/UserTaskSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/UnusedCredentialQuerySample/UnusedCredentialQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/TriggerAlarmSample/TriggerAlarmSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/TransactionManagerSample/TransactionManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/TimeAttendanceSample/TimeAttendanceSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ThumbnailQuerySample/ThumbnailQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ServerSample/ServerSample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/ServerInformationSample/ServerInformationSample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/SequenceQuerySample/SequenceQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/SecurityManagerSample/SecurityManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ScheduleSample/ScheduleSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ScheduledTaskSample/ScheduledTaskSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/RoleSample/RoleSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ResourceProviderSample/ResourceProviderSample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/RequestManagerSample/RequestManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ReportExporterSample/ReportExporterSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/RaiseEventSample/RaiseEventSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/PlaySoundSample/PlaySoundSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/PeopleCountingSample/PeopleCountingSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/PartitionSample/PartitionSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/MapSample/MapSample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/MacroSample/MacroSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/LprHitQuerySample/LprHitQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/LoginManagerSample/LoginManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol, keep error formatting consistent with new message usage. |
| Samples/Platform SDK/LoggerSample/LoggerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/LicenseManagerSample/LicenseManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/IntrusionDetectionQuerySample/IntrusionDetectionQuerySample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/IncidentManagerSample/IncidentManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/HealthEventQuerySample/HealthEventQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/HardwareInventoryQuerySample/HardwareInventoryQuerySample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/EventToActionSample/EventToActionSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/EventMonitoringSample/EventMonitoringSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/EntityMappingSample/EntityMappingSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/EntityCertificatesManagerSample/EntityCertificatesManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/EntityCacheSample/EntityCacheSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/DoorSample/DoorSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/DisplayInTileSample/DisplayInTileSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/DiagnosticServerSample/DiagnosticServerSample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/CustomReportQuerySample/CustomReportQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CustomIconSample/CustomIconSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CustomFieldSample/CustomFieldSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CustomEventSample/CustomEventSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CustomEntitySample/CustomEntitySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CustomCardFormatBuilderSample/CustomCardFormatBuilderSample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/CredentialBuilderSample/CredentialBuilderSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CopyConfigurationSample/CopyConfigurationSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CardholderSample/CardholderSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CameraSample/CameraSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CameraEventSample/CameraEventSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/CameraConfigurationSample/CameraConfigurationSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AuditTrailsSample/AuditTrailsSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ArchiverRoleSample/ArchiverRoleSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ArchiverEventQuerySample/ArchiverEventQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AlarmMonitoringSample/AlarmMonitoringSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AlarmActivityQuerySample/AlarmActivityQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ActivityTrailsSample/ActivityTrailsSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/ActionMonitoringSample/ActionMonitoringSample.csproj | Switch to conditional TargetFramework, update message text. |
| Samples/Platform SDK/AccessVerifierSample/AccessVerifierSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AccessRuleSample/AccessRuleSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AccessEventMonitoringSample/AccessEventMonitoringSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AccessControlUnitSample/AccessControlUnitSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AccessControlUnitManagerSample/AccessControlUnitManagerSample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AccessControlReportQuerySample/AccessControlReportQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/AccessControlRawEventQuerySample/AccessControlRawEventQuerySample.csproj | Switch to conditional TargetFramework, update message text, fix copyright symbol. |
| Samples/Platform SDK/README.md | Update documentation example to use conditional TargetFramework pattern. |
| README.md | Update repository-level documentation example to use conditional TargetFramework pattern. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.