Skip to content

pygmt.grdpaste: Join two grids along their common edge #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Chuan1937 wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

pygmt.grdpaste: Join two grids along their common edge #4399

Chuan1937 wants to merge 15 commits into from
+171 −0

Conversation

@Chuan1937
Copy link
Contributor

@Chuan1937 Chuan1937 commented Feb 9, 2026 •
edited by seisman
Loading

@Chuan1937 Chuan1937 mentioned this pull request Feb 9, 2026
Open
6 tasks
@seisman seisman added the feature Brand new feature label Feb 9, 2026
@seisman seisman added this to the 0.19.0 milestone Feb 9, 2026
seisman
seisman reviewed Feb 9, 2026
View reviewed changes
seisman
seisman reviewed Feb 9, 2026
View reviewed changes
Chuan1937 and others added 2 commits February 9, 2026 18:20
@Chuan1937 @seisman
Update pygmt/src/grdpaste.py
8d888ac 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/grdpaste.py
6260699 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman
Copy link
Member

seisman commented Feb 9, 2026

Also need to add it to doc/api/index.rst.

seisman
seisman reviewed Feb 9, 2026
View reviewed changes
@Chuan1937 Chuan1937 requested a review from seisman February 10, 2026 01:21
seisman
seisman reviewed Feb 10, 2026
View reviewed changes
@Chuan1937 @seisman
Update doc/api/index.rst
f641e8b 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 10, 2026
seisman
seisman reviewed Feb 10, 2026
View reviewed changes
Chuan1937 and others added 5 commits February 10, 2026 15:51
@Chuan1937 @seisman
Update pygmt/src/grdpaste.py
ff58d4e 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/grdpaste.py
53a0397 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 @seisman
Update pygmt/src/grdpaste.py
bfa2f25 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937
use temporary files for xarray.Data
18504b4
@Chuan1937
use temporary files
d23a3bf
@Chuan1937
Copy link
Contributor Author

Chuan1937 commented Feb 10, 2026 •
edited
Loading

Could you also please check the min and max values in the result?
Must use temporary files for xarray.DataArray inputs because virtualfile_in returns all zeros when handling grdpaste.

@Chuan1937 Chuan1937 requested a review from seisman February 10, 2026 08:50
@seisman
Copy link
Member

seisman commented Feb 10, 2026

Could you also please check the min and max values in the result? Must use temporary files for xarray.DataArray inputs because virtualfile_in returns all zeros when handling grdpaste.

I think this points to an upstream GMT bug, which should be fixed.

@seisman seisman removed the needs review This PR has higher priority and needs review. label Feb 10, 2026
@seisman seisman marked this pull request as draft February 10, 2026 09:07
@Chuan1937
Copy link
Contributor Author

Chuan1937 commented Feb 10, 2026

Could you also please check the min and max values in the result?xarray必须使用临时文件。DataArray 输入是因为 virtualfile_in 处理 grdpaste 时返回所有零。

我认为这指向上游的GMT漏洞，应该修复。

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seisman seisman Awaiting requested review from seisman

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feature Brand new feature

Projects

None yet

Milestone

0.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Chuan1937 @seisman