Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Feb 9, 2026

See #3707 (comment) for context. I think it makes more sense to raise GMTParameterError in this case.

The error message looks like:

In [1]: import pygmt
    
In [2]: fig = pygmt.Figure()

In [3]: fig.grdview(grid="@earth_relief_01d", surftype="surface", dpi=300)

GMTParameterError: Conflicting parameters: 'dpi' cannot be used with "surftype='surface'".
'dpi' is allowed only when 'surftype' is 'image'.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Feb 9, 2026
@seisman seisman added this to the 0.19.0 milestone Feb 9, 2026
@seisman seisman force-pushed the grdview/parametererror branch from 5baf5a0 to bd9fb90 Compare February 9, 2026 09:11
@seisman seisman changed the title Figure.grdview: Raise GMTParameterError when parameter conflicts with specified surftype Figure.grdview: Raise GMTParameterError when parameter conflicts with specific surftype Feb 9, 2026
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 9, 2026
@seisman seisman merged commit e436168 into main Feb 9, 2026
11 of 23 checks passed
@seisman seisman deleted the grdview/parametererror branch February 9, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants