Skip to content

pygmt.x2sys_cross: Deprecate parameter combitable to combi_table (Will be removed in v0.2X.0) #4293

Draft
yvonnefroehlich wants to merge 1 commit intomainfrom
deprecate-x2sys_cross-combitable
Draft

pygmt.x2sys_cross: Deprecate parameter combitable to combi_table (Will be removed in v0.2X.0) #4293
yvonnefroehlich wants to merge 1 commit intomainfrom
deprecate-x2sys_cross-combitable

Conversation

@yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 16, 2025

Description of proposed changes

Use underscores between words in parameter names; related to #2014.

Preview: https://pygmt-dev--4293.org.readthedocs.build/en/4293/api/generated/pygmt.x2sys_cross.html

Guidelines

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added this to the 0.18.0 milestone Dec 16, 2025
@yvonnefroehlich yvonnefroehlich self-assigned this Dec 16, 2025
@yvonnefroehlich yvonnefroehlich added the deprecation Deprecating a feature label Dec 16, 2025
@seisman
Copy link
Member

seisman commented Dec 17, 2025

The name combi_table is also not good. I guess we need to understand the option behavior and find a more suitable name for it.

@yvonnefroehlich yvonnefroehlich marked this pull request as draft December 17, 2025 03:56
@yvonnefroehlich
Copy link
Member Author

The name combi_table is also not good. I guess we need to understand the option behavior and find a more suitable name for it.

Agree. Set the PR to draft. Unfortunately, so far I did not use pygmt.x2sys_cross.

@seisman seisman removed this from the 0.18.0 milestone Dec 18, 2025
@yvonnefroehlich yvonnefroehlich changed the title pygmt.x2sys_cross: Deprecate parameter combitable to combi_table (Will be removed in v0.20.0) pygmt.x2sys_cross: Deprecate parameter combitable to combi_table (Will be removed in v0.21.0) Feb 6, 2026
@yvonnefroehlich yvonnefroehlich changed the title pygmt.x2sys_cross: Deprecate parameter combitable to combi_table (Will be removed in v0.21.0) pygmt.x2sys_cross: Deprecate parameter combitable to combi_table (Will be removed in v0.2X.0) Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants