Skip to content

8867b fixtest layout#8885

Merged
joa-quim merged 10 commits intoGenericMappingTools:masterfrom
ES-Solar:8867b-fixtest-layout
Feb 7, 2026
Merged

8867b fixtest layout#8885
joa-quim merged 10 commits intoGenericMappingTools:masterfrom
ES-Solar:8867b-fixtest-layout

Conversation

@ES-Solar
Copy link
Contributor

Corrected layout of fillTransparency baseline.

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@ES-Solar
Copy link
Contributor Author

I think I've brought the layout inline with the expected pattern.

@joa-quim
Copy link
Member

joa-quim commented Feb 3, 2026

When I run

C:\progs_cygw\GMTdev\gmt5\master>dvc pull
Collecting                                                                                                                         |0.00 [00:00,    ?entry/s]
WARNING: Some of the cache files do not exist neither locally nor on remote. Missing cache files:
md5: cd022252f83b80a3c67e52094323d52d
Fetching
Building workspace index                                                                                                         |1.30k [00:00, 2.40kentry/s]
Comparing indexes                                                                                                                |1.21k [00:00, 11.4kentry/s]
Applying changes                                                                                                                   |0.00 [00:00,     ?file/s]
Everything is up to date.
ERROR: failed to pull data from the cloud - Checkout failed for following targets:
test\baseline\postscriptlight\fillTransparency.ps

The file fillTransparency.ps should not be in postscriptlight. And apparently the fillTransparency.ps file is not in the DVC server.

@ES-Solar
Copy link
Contributor Author

ES-Solar commented Feb 3, 2026

Sorry to still have that mixed up. I've made a few more adjustments and the pull should work for you now.

@joa-quim
Copy link
Member

joa-quim commented Feb 3, 2026

Before I try. Does it work for you? 😄

@ES-Solar
Copy link
Contributor Author

ES-Solar commented Feb 3, 2026

Yes, I deleted the baseline and the cache entries locally, and dvc was able to pull the baseline image and then I successfully ran the ctest.

size: 26087
hash: md5
path: fillTransparency.ps
path: postscriptlight/fillTransparency.ps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put the ps file under postscriptlight. It should go to the program that is being tested (sorry, forgot the name, psxy?).

@ES-Solar
Copy link
Contributor Author

ES-Solar commented Feb 4, 2026

Ihad placed it there because I had modified the postscriptlight.c file to fix the bug and because there wasn't a 'plot' test directory.
I've now moved the fillTransparency test to be in the psxy test and baseline folders. I removed the baseline images, retested the dvc pull and the ctest steps.

@ES-Solar
Copy link
Contributor Author

ES-Solar commented Feb 4, 2026

Saw the issue with the Code Validator, I'm adjusting the test script to be more like the others

@joa-quim
Copy link
Member

joa-quim commented Feb 5, 2026

Well, that part now works ... but psldemo.ps got removed and now its tests fails

Comparing indexes                                                                          |1.21k [00:00, 4.23kentry/s]
ERROR: failed to pull data from the cloud - Can't remove the following unsaved files without confirmation. Use `--force` to force.
C:\progs_cygw\GMTdev\gmt5\master\test\baseline\postscriptlight\psldemo.ps

@ES-Solar
Copy link
Contributor Author

ES-Solar commented Feb 6, 2026

I've replaced the test/baseline/postscriptlight/psldemo.ps file in the dvc repository and verified pulling it

Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good now. Thanks and sorry for all this confusion. I hate the DVC but have nothing better to propose,

@joa-quim joa-quim merged commit baca64c into GenericMappingTools:master Feb 7, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants