WIP Ensure vector +z is nondimensional or uses unit q only#7047
Open
PaulWessel wants to merge 3 commits intomasterfrom
Open
WIP Ensure vector +z is nondimensional or uses unit q only#7047PaulWessel wants to merge 3 commits intomasterfrom
PaulWessel wants to merge 3 commits intomasterfrom
Conversation
See #7039 for discussion. The coding of modifier +z was expecting plot units but that makes no sense. This PR checks that either no unit or q is applied and errors otherwise.
Member
|
I have implemented patches Julia plot to workaround this bug and I think what I get is the right arrow. So, yes those tests have the wrong plots. |
Member
Author
|
OK, then I need a review t approve and I can update the PS later. |
Member
|
But the 2.54 factor is still there, as well as the problem when the axes are not isometric. See, I need to multiply by 2.54. Regarding the non-isometry, I found that multiplying the yy* by a scale factor given by (map_height / map_width) / ((y_max - y_min) / (x_max - x_min)) (9.5/14) / ((1.32+0.04)/(2.3+0.1)) * 1.27 = 1.5207983193277308 and a zscale given by map_width / (x_max - x_min) 14 / (2.3+0.1) / 2.54 = 2.2966 |
Member
Author
|
Added WIP back on. Maybe have time to look at this tomorrow, but times are busy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



See #7039 for discussion. The coding of modifier +z was expecting plot units but that makes no sense. This PR checks that either no unit or q is appended and errors otherwise.
Hi @joa-quim, if you have time, please note that vector2d_mods.sh and vector3d_mods.sh now fail (left column row 4) but I think those are not failures but confusion about what units are used etc. We are doing
Input: 2.20 1.27 Vector: -Sv20p+e+z1qSo with q that means the input is user units to be converted via -R -J to plot units, then scaled by 1. So given the previous plot row has
Input: 2.20 1.27 Vector: -Sv20p+e+z0.394q+c --PROJ_LENGTH_UNIT=inchit should be longer by 2.54. The --PROJ_LENGTH_UNIT should not have any implication here since input is not in plot units but in user units. Seems to me the original PS is wrong due to the bug we are trying to fix. Let me know what you think.