Skip to content

Add null check for sourceData in friend offline notification #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seer-by-sentry wants to merge 1 commit into from
Closed

Add null check for sourceData in friend offline notification #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions GenOnlineService/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,14 @@

{
// TODO_SOCIAL: Move this to a class
// inform any friends who are online that this person just came online
// inform any friends who are online that this person just came offline
WebSocketMessage_Social_FriendStatusChanged friendStatusChangedEvent = new();
friendStatusChangedEvent.msg_id = (int)EWebSocketMessageID.SOCIAL_FRIEND_ONLINE_STATUS_CHANGED;
if (sourceData != null)
{
friendStatusChangedEvent.display_name = sourceData.m_strDisplayName;
friendStatusChangedEvent.online = false;
byte[] bytesJSON = Encoding.UTF8.GetBytes(JsonSerializer.Serialize(friendStatusChangedEvent));
friendStatusChangedEvent.online = false;
byte[] bytesJSON = Encoding.UTF8.GetBytes(JsonSerializer.Serialize(friendStatusChangedEvent));

if (sourceData != null)
{
Expand Down Expand Up @@ -362,7 +364,7 @@
{

}
}

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Release) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

} expected

Check failure on line 367 in GenOnlineService/Constants.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

} expected

/*
public static ChatSession? GetWebSocketForUser(Int64 userID)
Expand Down Expand Up @@ -831,12 +833,12 @@
m_UserID = ownerID;

// TODO_SOCIAL: Move this to a class
// inform any friends who are online that this person just came online
// inform any friends who are online that this person just came offline
WebSocketMessage_Social_FriendStatusChanged friendStatusChangedEvent = new();
friendStatusChangedEvent.msg_id = (int)EWebSocketMessageID.SOCIAL_FRIEND_ONLINE_STATUS_CHANGED;
friendStatusChangedEvent.display_name = strDisplayName;
friendStatusChangedEvent.online = true;
byte[] bytesJSON = Encoding.UTF8.GetBytes(JsonSerializer.Serialize(friendStatusChangedEvent));
byte[] bytesJSON = Encoding.UTF8.GetBytes(JsonSerializer.Serialize(friendStatusChangedEvent));

// friends are reciprocal so we can just iterate our friends
foreach (Int64 friendID in socialContainer.Friends)
Expand Down
1 change: 1 addition & 0 deletions GenOnlineService/Constants_fixed.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
PLACEHOLDER

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, osx, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, win, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Release) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, osx, Release) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, linux-musl, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (arm64, win, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

Identifier expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

; expected

Check failure on line 1 in GenOnlineService/Constants_fixed.cs

View workflow job for this annotation

GitHub Actions / Build (x64, linux-musl, Debug) 

Identifier expected
Loading