Skip to content

Identify the board App by client-id, which app-id is deprecated in favour of #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rocklambros wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

Identify the board App by client-id, which app-id is deprecated in favour of #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/board-reconcile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ jobs:
id: token
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
app-id: ${{ vars.BOARD_APP_ID }}
# client-id, not app-id: create-github-app-token deprecated app-id and
# annotates every run that uses it. Both identify the same App and neither is
# a secret, so this is a rename rather than a change of trust.
client-id: ${{ vars.BOARD_APP_CLIENT_ID }}
private-key: ${{ secrets.BOARD_APP_PRIVATE_KEY }}
# Without an owner the token is scoped to this repository alone and cannot
# reach an organization-owned project. The App is installed with
Expand Down
Loading