ci: gate the c and nix workflows to upstream so they skip on forks#259
Conversation
The c (`build_test`) and nix (`check`, `build`) jobs target runner labels (linux-x86_64-16cpu, linux-arm64-16cpu, windows-8vcpu) that only exist in the upstream org. On a fork those runners do not exist, so every push and PR left these jobs queued indefinitely — clogging the Actions tab, never reporting, and gating nothing. The rust (ci), elixir, and python workflows already guard the same labels behind `github.repository_owner == 'tailscale'`; c and nix were the two that missed the guard. Add the same job-level guard so they skip cleanly off-upstream. The real fork gates (hosted test + musl static on the fork's own self-hosted Linux runners) are unaffected. Signed-off-by: GeiserX <9169332+GeiserX@users.noreply.github.com>
|
Warning Review limit reached
More reviews will be available in 47 minutes and 28 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Problem
On this fork, every push and PR left jobs queued indefinitely (observed:
candnixjobs stuckqueuedfor 2+ hours, gating nothing and clogging the Actions tab).Cause: the
c(build_test) andnix(check,build) jobs target runner labels —linux-x86_64-16cpu,linux-arm64-16cpu,windows-8vcpu— that only exist in the upstreamtailscale/tailscale-rsorg. The fork has no runners with those labels, so the jobs can never be picked up; they just queue forever.The
rust(ci.yml),elixir, andpythonworkflows already guard these exact labels behindif: ${{ github.repository_owner == 'tailscale' }}.candnixwere the two workflows that missed the guard.Fix
Add the same job-level owner guard to
c'sbuild_testand both ofnix's jobs (check,build), so they skip cleanly off-upstream instead of queuing forever.The fork's real gates are unaffected —
hosted test (self-hosted Linux)andmusl static (…)run on the fork's own[self-hosted, Linux, X64]runners and remain the green signal.Verification
Both workflow files parse (
yaml.safe_load); guards are job-level (beforeruns-on/strategy), matching the existing pattern inci.yml/elixir.yml/python.yml. Diff is +14 lines, comments only + theif:guards — no behavior change for upstream.Signed-off-by: Sergio sergio@geiser.cloud
Created using Claude Code (Opus 4.8)