Skip to content

docs: stop telling macOS users the signed app is unsigned - #183

Merged
GeiserX merged 1 commit into
mainfrom
docs/macos-signed-wording
Oct 13, 2026
Merged

GeiserX merged 1 commit into
mainfrom
docs/macos-signed-wording

Conversation

@GeiserX

@GeiserX GeiserX commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

The getting-started page still told macOS users the app is unsigned and that they had to right-click it and choose Open. That stopped being true on 2026-10-04, when #164 made desktop-release.yml sign and notarize the macOS build. The current release, v0.20.10, carries my Developer ID signature for team 624WUVM8B4 with the notarization ticket stapled, and spctl answers accepted, source=Notarized Developer ID.

The macOS row now says to double-click the app. It also names the bundle the zip really contains, cashpilot-desktop.app, instead of CashPilot Desktop.app. I left the Windows row alone because the repo has no Windows signing certificate yet, so it is still unsigned.

Summary by CodeRabbit

  • Documentation
    • Updated macOS Apple Silicon download instructions to note that the app is signed and notarized, opens with a double-click, and prompts once for confirmation.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: GeiserX/CashPilot-Desktop/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6445ca1d-6d1a-4898-8e25-e5eb144e7e7d
📥 Commits

Reviewing files that changed from the base of the PR and between c8ca738 and c27314c.

📒 Files selected for processing (1)
  • docs/getting-started.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The macOS getting-started instructions now identify the app as signed and notarized, describe opening it by double-clicking, and note a one-time confirmation for an internet download.

Changes: macOS download instructions

Layer / File(s) Summary
Update macOS opening instructions
docs/getting-started.md
The guide identifies cashpilot-desktop.app as signed and notarized, says to open it by double-clicking, and describes a one-time confirmation. It removes the previous right-click/Open instructions and unsigned-app warning.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to c2731

The guide names the packaged app and describes the signed, notarized release path. No material merge risk is apparent.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the documentation change: it corrects the macOS instructions for the signed application.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.95%. Comparing base (c8ca738) to head (c27314c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files          33       33           
  Lines        5232     5232           
=======================================
  Hits         4340     4340           
  Misses        591      591           
  Partials      301      301           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GeiserX
GeiserX merged commit ed6386a into main Oct 13, 2026
9 checks passed
@GeiserX
GeiserX deleted the docs/macos-signed-wording branch October 13, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant