Repository navigation
fix(catalog): catch up with the web catalog and point at a wrong-shaped key in the form - #179
Merged
Merged
Conversation
…ed key in the form The vendored catalog was missing the Storj Chapter 11 caution, the Repocket API key pattern, Noderr and Sia hostd. The sync refused to run because Sia hostd ships a floating image with no digest pin here, so the pin comes first and the README lists the two new services with the counts the tests check. The web app's #428 taught the deploy form to hand a catalog pattern to the browser and refuse a wrong-shaped value before anything is sent. The backend here already enforced the pattern on every deploy; now the wizard renders it on the input, asks the browser for a new secret rather than a saved password, and reports the first invalid field before Save or Deploy. The render checks cover the attribute and were watched failing without it.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 33 33
Lines 5232 5232
=======================================
Hits 4340 4340
Misses 591 591
Partials 301 301 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop's catalog had fallen behind the web app: no Storj Chapter 11 caution (GeiserX/CashPilot#427), no Repocket API key pattern (GeiserX/CashPilot#428), and neither Noderr nor Sia hostd. The sync could not even run, because Sia hostd ships a floating image and the overlay had no digest pin for it. Drift issue #177 has been open since this morning's run.
This pins Sia hostd's manifest-list digest, syncs the catalog from the web repo, and lists the two new services in the README with the counts the tests check. It also ports the one behaviour change from #428 that Desktop lacked: the wizard now renders a catalog pattern on the input, asks the browser for a new secret instead of a saved password, and points at the first wrong-shaped value before Save or Deploy. The Go backend already enforced the pattern on every deploy, so the gate was in place; this is the early warning in the form.
Neither new service has a referral programme (Sia hostd is permissionless; the Noderr project confirmed none in the web repo's #409), so the links are the catalog's signup URLs.
Closes #177.