Skip to content

docs: say that every web PR touching the catalog, the deploy path or a guide has a counterpart here - #178

Merged
GeiserX merged 1 commit into
mainfrom
docs/web-parity-rule
Oct 12, 2026
Merged

GeiserX merged 1 commit into
mainfrom
docs/web-parity-rule

Conversation

@GeiserX

@GeiserX GeiserX commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

The web repo's #427 and #428 changed the catalog and the deploy validation this week, and nothing told whoever merged them to come here. The catalog is now missing the Storj caution, the Repocket key pattern, Noderr and Sia hostd, and the drift issue #177 is open.

CLAUDE.md gets a short section: the web repo leads, these are the files that mirror it, and the three steps a web PR owes this repo in the same session. The web repo gets the matching rule and a PR checklist line in GeiserX/CashPilot#429.

Summary by CodeRabbit

  • Documentation
    • Clarified how catalog changes are synchronized between the web and desktop repositories, including ownership of updates and the role of the weekly drift check.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: GeiserX/CashPilot-Desktop/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4d1b1d04-5253-4871-a8d1-f5095ff721c3

📥 Commits

Reviewing files that changed from the base of the PR and between 2feffe1 and 174b06a.


📒 Files selected for processing (1)
  • CLAUDE.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

CLAUDE.md now documents how to sync the desktop catalog with the web repository, port behavior changes and tests, and distinguish catalog drift checks from behavior checks.

Changes

Catalog sync guidance

Layer / File(s) Summary
Catalog and behavior sync instructions
CLAUDE.md
Adds catalog check and sync steps, instructions for resolving unpinned live images through catalog-overlay/image-pins.yml, and guidance to port behavior changes and tests. It states that the weekly workflow checks catalog drift only.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 174b0

The new guidance matches the repository’s catalog tooling and weekly drift workflow. No material merge risk remains.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the added guidance for coordinating related web and desktop repository changes. It is specific and directly related to the main change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GeiserX
GeiserX merged commit 2793220 into main Oct 12, 2026
7 checks passed
@GeiserX
GeiserX deleted the docs/web-parity-rule branch October 12, 2026 18:47
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.95%. Comparing base (3d3b891) to head (174b06a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files          33       33           
  Lines        5232     5232           
=======================================
  Hits         4340     4340           
  Misses        591      591           
  Partials      301      301           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant