Skip to content

chore(ci): pin pr-governance to i18n allowlist - #140

Merged
Pigbibi merged 1 commit into
masterfrom
chore/pin-pr-governance-i18n-allowlist
Nov 13, 2026
Merged

Pigbibi merged 1 commit into
masterfrom
chore/pin-pr-governance-i18n-allowlist

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

改动内容

把 gitleaks / secret-scan 相关 workflow 的 pr-governance pin 更新到包含 i18n 文案目录豁免的治理提交 4c296692ae2efbce09bc21b6641299f368435c40。

不改会怎样

继续使用旧 pin 时,configuration-secret-value 仍可能把 token.expired 这类 i18n key 误判为凭据;治理仓正式豁免无法被应用仓生效。

怎么验证的

# 治理仓本地
cd pr-governance && GITLEAKS_BIN=/usr/local/bin/gitleaks python3 -m unittest scripts.test_secret_scan
# 结果:41 tests OK

本 PR 只改 workflow pin,应用仓 CI 的 Gitleaks / Repository hygiene / Commit message convention 已通过。

检查清单

  • 上面列出的检查已通过,或有说明为什么没跑
  • 改动涉及的行为变化,已在同一次 PR 里更新对应文档
  • 没有提交真实账号、密码、验证码、Token、Cookie 或他人个人信息
  • 没有提交密钥、证书、local.properties 或环境配置文件

涉及隐私、权限或数据流的改动

不涉及。

关联 Issue

无。

AI 辅助

Cursor(Composer)协助起草 pin 同步与 PR 描述。

风险

低。仅更新 GitHub Actions uses: pin;运行时与业务代码不变。依赖治理仓提交 4c29669 已可达(.github #11 已合并)。

Pick up the configuration-secret-value allowlist for message catalogs
so token.* i18n keys stop failing secret scan.

Co-authored-by: Cursor <cursoragent@cursor.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T14:20:57.715505Z 07fe9c2 PR opened
🔒 Security Review ✅ Completed 2026-11-13T14:22:25.524112Z 07fe9c2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Pigbibi Pigbibi added the owner-approved Owner verified high-risk approval label Nov 13, 2026
@Pigbibi
Pigbibi merged commit 9766018 into master Nov 13, 2026
18 of 20 checks passed
@Pigbibi
Pigbibi deleted the chore/pin-pr-governance-i18n-allowlist branch November 13, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved Owner verified high-risk approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant