Skip to content

fix(governance): require review at R0 and split label recording - #7

Merged
Pigbibi merged 1 commit into
mainfrom
chore/sync-action-fixes
Nov 7, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
chore/sync-action-fixes

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

AI 参与

Codex 对发布 PR 提出 4 项 P1,均已修复;本地 node --test 161 项、test_secret_scan 40 项全部通过。

改动内容

同步 QuantStrategyLab/.github#49 合入的门禁修复到本仓 pr-governance/:

  • R0 也必须有当前 head 的审查回执,不再用 review_not_required 直接通过;R0 只降低清理标签要求。
  • 策略或默认分支读取失败时不再抛错留旧状态,而是把三个检查改写为阻断性的 error,避免陈旧绿色通行。
  • recordLabel 与评估拆成两个派发路径:新增 record-label 输入,risk-gate 模板里记录 job 传 true、评估 job 传 false,评估 job 真正执行。
  • 密钥范围扫描加入 --diff-merges=first-parent,合并冲突里引入的凭据同样会被检出,并补充回归用例。

怎么验证的

  • node --test:161 通过 0 失败(新增记录/评估分流、策略不可用改写阻断状态的用例)。
  • python3 -m unittest test_secret_scan:40 通过,含合并提交范围扫描用例。
  • 文件名与 feat: add the shared PR governance action QuantStrategyLab/.github#49 合并后内容一致(gate/main/runner/secret_scan/action/templates)。

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T13:21:42.521931Z 9d4ac66 PR opened
🔒 Security Review ✅ Completed 2026-11-07T13:23:15.482697Z 9d4ac66 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant