Skip to content

release: promote thread query fix to v1 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 2 commits into from
Nov 7, 2026
Merged

release: promote thread query fix to v1 #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa28bdf
fix(governance): stop querying databaseId on Actor
Pigbibi Nov 7, 2026
dd96c01
Merge pull request #5 from GdeiAssistant/fix/thread-author-query
Pigbibi Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pr-governance/scripts/runner.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ async function readThreads(github, repo, number) {
const data = await github.graphql(`query($owner:String!,$repo:String!,$number:Int!,$cursor:String) {
repository(owner:$owner,name:$repo) { pullRequest(number:$number) {
reviewThreads(first:100,after:$cursor) {
nodes { id isResolved isOutdated comments(first:1) { nodes { author { login databaseId } } } }
nodes { id isResolved isOutdated comments(first:1) { nodes { author { login } } } }
pageInfo { hasNextPage endCursor }
}
} }
Expand All @@ -80,8 +80,7 @@ async function readThreads(github, repo, number) {
for (const node of page.nodes) {
if (!node?.id || typeof node.isResolved !== 'boolean') throw new Error('Invalid review thread');
threads.push({ id: node.id, isResolved: node.isResolved, isOutdated: node.isOutdated === true,
author: { login: node.comments?.nodes?.[0]?.author?.login ?? null,
id: node.comments?.nodes?.[0]?.author?.databaseId ?? null } });
author: { login: node.comments?.nodes?.[0]?.author?.login ?? null } });
}
const next = page.pageInfo.hasNextPage ? page.pageInfo.endCursor : null;
if (page.pageInfo.hasNextPage && (!next || next === cursor)) throw new Error('Invalid thread page');
Expand Down
2 changes: 2 additions & 0 deletions pr-governance/scripts/test-runner.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ test('review threads paginate to the last page and refuse a repeating cursor', a
let page = 0;
m.github.graphql = async (query, params) => {
page++;
// `Actor` has no databaseId field; asking for one makes every evaluation fail.
assert.doesNotMatch(query, /databaseId/);
assert.equal(params.cursor, page === 1 ? null : 'cursor1');
return { repository: { pullRequest: { reviewThreads: {
nodes: [{ id: `thread-${page}`, isResolved: page === 1, comments: { nodes: [{ author: { login: 'agent' } }] } }],
Expand Down
Loading