Skip to content

Feature/1265 venue address search#1451

Merged
mauteri merged 29 commits intoGatherPress:developfrom
jmarx:feature/1265-venue-address-search
Apr 17, 2026
Merged

Feature/1265 venue address search#1451
mauteri merged 29 commits intoGatherPress:developfrom
jmarx:feature/1265-venue-address-search

Conversation

@jmarx
Copy link
Copy Markdown
Collaborator

@jmarx jmarx commented Apr 4, 2026

Description of the Change

Adding type ahead functionality when selecting addresses.

Closes #1265

How to test the Change

Start typing an address. The type ahead should kick in with at least 3 characters.

Screenshot 2026-04-05 at 5 09 53 PM Screenshot 2026-04-05 at 5 15 25 PM

Changelog Entry

Added - New feature

Credits

Props @jmarx

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • [ X] All new and existing tests pass.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2026

Test Coverage Report

All coverage checks passed!

PHP Coverage
=== PR Coverage Check ===

Configuration loaded:
  Minimum coverage: 100%
  Exclude patterns: 42 patterns
  Low coverage exceptions: 0 files

Checking coverage for files changed from origin/develop...

Found 10 changed PHP file(s):
  - includes/core/classes/class-geocoding.php
  - includes/core/classes/class-settings.php
  - includes/core/classes/class-venue.php
  - test/unit/php/includes/tests/core/classes/class-test-event-admin-list.php
  - test/unit/php/includes/tests/core/classes/class-test-geocoding-multisite.php
  - test/unit/php/includes/tests/core/classes/class-test-geocoding.php
  - test/unit/php/includes/tests/core/classes/class-test-settings.php
  - test/unit/php/includes/tests/core/classes/class-test-venue.php
  - test/unit/php/includes/tests/core/classes/commands/class-test-settings-cli.php
  - test/unit/php/includes/tests/core/classes/settings/class-test-tools.php

Files requiring coverage check: 3
  - includes/core/classes/class-geocoding.php
  - includes/core/classes/class-settings.php
  - includes/core/classes/class-venue.php

✅ Loaded coverage.xml
✅ Loaded coverage-multisite.xml

✅ includes/core/classes/class-geocoding.php - 100% coverage (277/277 lines)
✅ includes/core/classes/class-settings.php - 100% coverage (374/374 lines)
✅ includes/core/classes/class-venue.php - 100% coverage (406/406 lines)

=== Summary ===
✅ Passed: 3 file(s)
⏭️  Excluded: 7 file(s)
❌ Failed: 0 file(s)

✅ All changed files meet the minimum coverage requirement of 100%
JavaScript Coverage
=== PR JavaScript Coverage Check ===

Configuration loaded:
  Minimum coverage: 100%
  Exclude patterns: 42 patterns

Checking coverage for JavaScript files changed from origin/develop...

Found 11 changed JavaScript file(s):
  - src/blocks/venue-detail/edit.js
  - src/blocks/venue-detail/fields/address-field.js
  - src/blocks/venue-detail/hooks/use-geocoding.js
  - src/blocks/venue/index.js
  - src/components/AddressAutocompleteField/index.js
  - src/components/AddressAutocompleteField/use-address-autocomplete.js
  - src/components/AddressAutocompleteField/use-address-field-anti-autofill.js
  - src/components/OpenStreetMap.js
  - src/components/VenueForm.js
  - src/components/VenueInformation.js
  - src/helpers/geocoding.js

Files requiring coverage check: 2
  - src/blocks/venue-detail/fields/address-field.js
  - src/helpers/geocoding.js

✅ src/blocks/venue-detail/fields/address-field.js - 100% coverage (1/1 statements)
✅ src/helpers/geocoding.js - 100% coverage (68/68 statements)

=== Summary ===
✅ Passed: 2 file(s)
⏭️  Excluded: 9 file(s)
❌ Low coverage: 0 file(s)
❌ Missing coverage: 0 file(s)

✅ All changed JavaScript files meet the minimum coverage requirement of 100%

This comment is automatically updated on each push.


$parts = array_filter(
array_map( 'trim', $parts ),
static function ( $p ) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static function ( $p ): bool {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauteri fixed

@jmarx jmarx marked this pull request as ready for review April 5, 2026 21:12
@jmarx jmarx requested a review from mauteri April 5, 2026 21:12
@dd32
Copy link
Copy Markdown
Contributor

dd32 commented Apr 10, 2026

https://operations.osmfoundation.org/policies/nominatim/#:~:text=Unacceptable%20Use,using%20the%20API.

Unacceptable Use
The following uses are strictly forbidden and will get you banned:

  • Auto-complete search This is not yet supported by Nominatim and you must not implement such a service on the client side using the API.

Obviously it's supported by the API, but not the usage terms, are you aware of this changing?

@jmarx
Copy link
Copy Markdown
Collaborator Author

jmarx commented Apr 10, 2026

https://operations.osmfoundation.org/policies/nominatim/#:~:text=Unacceptable%20Use,using%20the%20API.

Unacceptable Use
The following uses are strictly forbidden and will get you banned:

  • Auto-complete search This is not yet supported by Nominatim and you must not implement such a service on the client side using the API.

Obviously it's supported by the API, but not the usage terms, are you aware of this changing?

@dd32 Nice catch! I will check this out and see if I can find a viable alternative(I think I already found one). cc @mauteri

@github-actions
Copy link
Copy Markdown
Contributor

Preview changes with Playground

You can preview the recent changes for PR#1451 with the following PHP versions:

PHP Version 8.4

PHP Version 8.2

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit dcc97f5 into GatherPress:develop Apr 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI of Venue Address Picker: Provide search results from geolocation provider

3 participants