Skip to content

updated test file of gp test#1048

Open
Prayag11 wants to merge 2 commits intoGatherPress:developfrom
prashantabellad:updated-tests
Open

updated test file of gp test#1048
Prayag11 wants to merge 2 commits intoGatherPress:developfrom
prashantabellad:updated-tests

Conversation

@Prayag11
Copy link
Copy Markdown
Contributor

@Prayag11 Prayag11 commented Apr 15, 2025

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Apr 15, 2025

PR Summary

  • Enhancements to Event Date Retrieval
    This update refines the approach we use to obtain and compare event dates from both the frontend and backend in the 'gatherpress-admin-event-details.spec.js' file.

  • Improved Venue Selection Option Descriptions
    We have updated the venue selection options in both 'gatherpress-admin-event-details.spec.js' and 'gatherpress-event-venue-map.spec.js' files. They are now more descriptive and should be easier to understand for users.

  • Screenshot Comparison Update
    With the updates in 'gatherpress-admin-event-details.spec.js', we have removed the older screenshot comparison logic and incorporated a new strategy to capture and validate screenshots for event dates.

  • Test Case Alteration
    In 'gatherpress-admin-venue-map.spec.js', we have chosen to skip a specific test case concerning the creation of venues for offline events.

  • Snapshot Test Modifications for Different Browsers
    This update enhances multiple snapshot tests, introducing new images for different browsers like Edge, Firefox, and WebKit. Older snapshots related to venues have been removed.

  • Timeout Adjustments and Viewport Size Changes
    We have adjusted timeouts and altered viewport sizes across several '.spec.js' files. This will significantly improve how we handle various tests. For instance, the viewport size setting in 'gatherpress-event-loggedIn.spec.js' has been removed.

  • Better Visibility Checks for RSVP Button
    In 'gatherpress-event-nonLoggegIn.spec.js', we have streamlined the checks for RSVP button visibility, leading to easier comprehension and maintenance of conditions checked.

  • Updated Toggle Handling for Venue Maps
    Finally, in 'gatherpress-venue-map-toggle-OFF.spec.js', we have refined the logic used to handle the toggle for venue maps. This will ensure UI elements align better with visibility expectations.

@mauteri
Copy link
Copy Markdown
Contributor

mauteri commented Apr 24, 2025

@01Prayag you have some merge conflicts to resolve before we can merge this. Thanks!

@01Prayag
Copy link
Copy Markdown
Contributor

I will check this and resolve..

@mauteri
Copy link
Copy Markdown
Contributor

mauteri commented Dec 7, 2025

@Prayag11 is this a PR you're still working on or can this be closed? Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants