You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enhancements to Event Date Retrieval
This update refines the approach we use to obtain and compare event dates from both the frontend and backend in the 'gatherpress-admin-event-details.spec.js' file.
Improved Venue Selection Option Descriptions
We have updated the venue selection options in both 'gatherpress-admin-event-details.spec.js' and 'gatherpress-event-venue-map.spec.js' files. They are now more descriptive and should be easier to understand for users.
Screenshot Comparison Update
With the updates in 'gatherpress-admin-event-details.spec.js', we have removed the older screenshot comparison logic and incorporated a new strategy to capture and validate screenshots for event dates.
Test Case Alteration
In 'gatherpress-admin-venue-map.spec.js', we have chosen to skip a specific test case concerning the creation of venues for offline events.
Snapshot Test Modifications for Different Browsers
This update enhances multiple snapshot tests, introducing new images for different browsers like Edge, Firefox, and WebKit. Older snapshots related to venues have been removed.
Timeout Adjustments and Viewport Size Changes
We have adjusted timeouts and altered viewport sizes across several '.spec.js' files. This will significantly improve how we handle various tests. For instance, the viewport size setting in 'gatherpress-event-loggedIn.spec.js' has been removed.
Better Visibility Checks for RSVP Button
In 'gatherpress-event-nonLoggegIn.spec.js', we have streamlined the checks for RSVP button visibility, leading to easier comprehension and maintenance of conditions checked.
Updated Toggle Handling for Venue Maps
Finally, in 'gatherpress-venue-map-toggle-OFF.spec.js', we have refined the logic used to handle the toggle for venue maps. This will ensure UI elements align better with visibility expectations.
@Prayag11 is this a PR you're still working on or can this be closed? Thx!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: