Enforce password strength check in createAdmin.ts - #908
Open
iamtanuj18 wants to merge 2 commits into
Open
Conversation
…/ctrl into 907-createadmin-strength-check
Contributor
|
Just a question @iamtanuj18 - did you test this with minikube locally on your laptop (via the |
Author
|
Evidence of correct behaviour from local minikube run — weak ORG_ADMIN_PASSWORD → CrashLoopBackOff with strength policy error at createAdmin.ts:14. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a password strength check inside createAdmin.ts before hashing ORG_ADMIN_PASSWORD. If the env var doesn't meet the strength policy, the deploy halts at container startup and the sysadmin sees the error in kubectl logs.
Fixes #907