Update e2e test to use new test data - #904
Merged
Merged
Conversation
This refactors `application/common/package.json` so that running `yarn test` includes the e2e tests. This will hopefully prevent similar bug being caught by CI first in the future.
plouka13
approved these changes
Jul 31, 2026
plouka13
left a comment
plouka13
left a comment
Contributor
There was a problem hiding this comment.
Noice! Good to see a simple fix for the e2e tests :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #903
application/common/cypress/e2etests had not yet been updated to used new refactored test data.Unfortunately this was only picked up in CI. This is because running
yarn testin the root of the repo runsyarn testin each workspace, but the e2e tests were not part of theapplication/commontest yarn script.This PR fixes the Bug in the test but also edits the
application/common/package.jsonto have separatejestande2escripts, and runs both as part ofyarn test.