Expand commonPasswordBaseWords with common weak passwords - #899
Open
iamtanuj18 wants to merge 4 commits into
Open
Expand commonPasswordBaseWords with common weak passwords#899iamtanuj18 wants to merge 4 commits into
iamtanuj18 wants to merge 4 commits into
Conversation
…/ctrl into 889-add-common-password-base-words
The admin test users all used 'Loginforadmin1' which now contains 'admin' as a blocked substring after this PR's blocklist expansion, causing integration tests to fail on registration. Switched to 'Loginfortests123' which matches the pattern already used by other tests and passes all current checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #889
Expands
commonPasswordBaseWordsfrom 3 to 65 entries. Sources are aggregated from Wikipedia's List of the most common passwords, which pulls from NordPass, SplashData, Keeper, NCSC/HIBP, and Huntress top-password reports.'i'flag)Also updates the error message in
PasswordStrength.tsto show the specific matched pattern instead of listing all 65 blocked words. The previousjoin(', ')format would produce a wall of text with the expanded list. This addresses the "user-facing guidance" point flagged in the issue. Cypress assertions inadmin-client/passwordReset.cy.jsanduser-client/registration.cy.jsupdated to match.Test admin passwords updated from
Loginforadmin1→Loginfortests123becauseadminis now in the blocklist and broke backend integration tests.TestUsersis test-only, no prod/env impact.