Security patches, fix broken test and tiny nix flake change - #896
Conversation
|
Note @iamtanuj18 @plouka13, if we upgrade react-router to v8 in the future it will involve removing react-router-dom and some code changes: https://github.com/remix-run/react-router/blob/main/CHANGELOG.md |
|
Note: I had to upgrade the This illustrates that using hashes is a slightly brittle way to test the logo resize function... but I don't have bandwidth to think about a more fuzzy way to verify this at the moment 🤷 If you have ideas feel free to create an issue and suggest them |
nix flake changenix flake change
plouka13
left a comment
There was a problem hiding this comment.
No issues with the code. Tested locally everything seems to work as expected. LGTM!
| const { id } = useResource() | ||
|
|
||
| const { queryResult } = useShow({ resource: 'surveys' }) | ||
| const { id: surveyId } = useParams() |
There was a problem hiding this comment.
Good name change choice - confused about which resource id it was before the change.
| import { useSurveyStore } from '../../surveyStore' | ||
| import { axiosInstance } from '../../providers/dataProvider' | ||
| import { useResource, useShow, useUpdate, useNavigation, useNotification } from '@refinedev/core' | ||
| import { useShow, useUpdate, useNavigation, useNotification } from '@refinedev/core' |
There was a problem hiding this comment.
Seems like a lot of these hooks are re-implementations of the react hooks from this change. Do you reckon there's a need to move away from some of these custom hooks to avoid dependency on refine?
Out of scope for this PR.
There was a problem hiding this comment.
Yeah - I don't have a strong view on this at the moment. Would have to have a think about it 🤔

Resolves #895