Blasting Maces #1255
Blasting Maces #1255
Conversation
TheThanathor
left a comment
TheThanathor
left a comment
There was a problem hiding this comment.
I've left a few comments for small issues, adding some bigger points here:
- I'm not really a fan of the level 2 of this enchantment, breaking a 5x5 area "feels" off to me, it's kind of breaking with the one-block-at-a-time philosophy (yes I know the 3x3 does as well, but it's kind of okay somehow?) Personally I'd like to more if it's just the single level for the enchantment, but good to get more views on this.
- The biggest improvement that could be made is to make use of local coordinates (the
^things) so you don't need different functions for each orientation. - In my opinion it would make more sense for the breaking orientation to depend on the face of the block the player targeted instead of their facing direction (this might be hard to figure out though)
- Also up for debate, should the breaking count as if it was broken by an explosion? (so metallurgy drops), it would make sense lore wise. The Mace is late game enough that I feel it would probably not be too overpowered, but need more input on this.
I've tested the module in-game and everything worked as expected, though I didn't test the dark magic Guidebook
There was a problem hiding this comment.
This doesn't seem to be intentional
| }, | ||
| "anvil_cost": 4, | ||
| "slots": [ | ||
| "any" |
There was a problem hiding this comment.
| "any" | |
| "mainhand" |
| scoreboard objectives add gm4_blast_data dummy | ||
|
|
||
| # scoreboard for tracking mace usage | ||
| scoreboard objectives add gm4_use_mace used:mace |
There was a problem hiding this comment.
| scoreboard objectives add gm4_use_mace used:mace | |
| scoreboard objectives add gm4_blast_use_mace used:mace |
It's better to use your prefix for everything, just in case
| execute if items entity @s weapon.mainhand minecraft:mace run item modify entity @s weapon.mainhand gm4_blasting_maces:add_tool | ||
| execute if items entity @s weapon.offhand minecraft:mace run item modify entity @s weapon.offhand gm4_blasting_maces:add_tool |
There was a problem hiding this comment.
You should check to make sure the mace you're changing is actually enchanted. Right now it can change an unenchanted mace if you're holding an enchanted one in the other hand
| execute if items entity @s weapon.mainhand minecraft:mace run item modify entity @s weapon.mainhand gm4_blasting_maces:remove_tool | ||
| execute if items entity @s weapon.offhand minecraft:mace run item modify entity @s weapon.offhand gm4_blasting_maces:remove_tool |
There was a problem hiding this comment.
Same as the one before, check to make sure the mace doesn't have the enchantment
| execute store result score @s gm4_blast_pitch run data get entity @s Rotation[1] 1 | ||
| execute store result score @s gm4_blast_yaw run data get entity @s Rotation[0] 1 |
There was a problem hiding this comment.
If you only need these if $success gm4_blast_data is 1 add a check here to save on possible player nbt reading. It's probably also better to copy the player Rotation into storage, then setting scores from that
| # run from gm4_blasting_maces:player/blast | ||
|
|
||
| # get max damage - 1 for mace (durability 500) | ||
| scoreboard players set $max_damage gm4_blast_data 499 |
There was a problem hiding this comment.
Check for existence of a damage component on the item first, in case it has custom durability, also check if it has the unbreakable tag!
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
| { | |
| { | |
| "replace": false, |
You need this or it'll override the vanilla tag
There was a problem hiding this comment.
it defaults to "replace": false, so it's not actually necessary
| - gm4_resource_pack | ||
| notes: [] | ||
| video: null | ||
| wiki: null |
There was a problem hiding this comment.
You can add a wiki link here, since they're always named after the module
| wiki: null | |
| wiki: "https://wiki.gm4.co/wiki/Blasting_Maces" |
| wiki: null | ||
| credits: | ||
| Creator: | ||
| - Drodo |
There was a problem hiding this comment.
You're not in our gm4/contributors.json yet, you should add an entry for yourself there (can use an empty list if you don't have a link)
3 participants
Blasting Maces module submission.
Adds a new Blasting enchantment that allows the player to dig areas of 3x3 (with Blasting I) and 5x5 (with Blasting II). The breaking area is directional, depending on where the player is looking. Durability loss scales with the number of blocks broken.
The module also takes the grindstone into account, adding or removing the tool component when the item is enchanted or when the enchantment is removed via a grindstone.