winex11.drv: Fix mouse input for builds without XInput2#7
Open
jeremybernstein wants to merge 1 commit intoGameNative:proton_10.0from
Open
winex11.drv: Fix mouse input for builds without XInput2#7jeremybernstein wants to merge 1 commit intoGameNative:proton_10.0from
jeremybernstein wants to merge 1 commit intoGameNative:proton_10.0from
Conversation
Update dlls_winex11_drv_mouse_c.patch with relative motion synthesis and WM_INPUT generation fix for no-XInput2 builds (Android/Termux). Based on Smuger's WM_INPUT fix from PR GameNative#6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
dlls_winex11_drv_mouse_c.patchto fix mouse input in builds compiled without XInput2 support (e.g. Android/Termux X11 with--without-xinput2).This builds on @Smuger's work in #6, which identified that
SEND_HWMSG_NO_RAWmust not be used when XInput2 is unavailable, since there is no explorer.exe raw input pipeline to generate WM_INPUT centrally.Changes
get_send_mouse_flags()helper that returnsSEND_HWMSG_NO_RAWwhen XInput2 is available, or0when absent, so each process generates its own WM_INPUT messagesX11DRV_MotionNotifyinstead of refusing to clip#ifdef HAVE_X11_EXTENSIONS_XINPUT2_Hguard aroundgrab_clipping_window()so clipping works in no-XInput2 buildspXFixesHideCursor/pXFixesShowCursorcalls on Android (crashes on Termux X11)Problem
Without XInput2, upstream Wine refuses cursor clipping entirely, which breaks mouse look/camera control in games. The previous patch only had the XFixes workaround. This extends it with proper relative motion support.
Test plan