Skip to content

fix(wrappergenerator): ApplyAttribute 抽取超时特性应用方法（S3776） #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlianBlank merged 1 commit into from
Nov 1, 2026
Merged

fix(wrappergenerator): ApplyAttribute 抽取超时特性应用方法（S3776） #950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions GameFrameX.Hotfix.WrapperGenerator/Agent/HotfixWrapperGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,20 +433,7 @@ private static void ApplyAttribute(List<Diagnostic> diagnostics, string fullName
}
else if (string.Equals(name, StripAttributeSuffix(TimeOutAttributeName), StringComparison.OrdinalIgnoreCase))
{
mth.TimeOut = ParseTimeout(attribute, out var parsed);
if (parsed)
{
mth.HasTimeout = true;
}
else
{
// 解析失败降级为未配置超时（走 EnqueueAsync 框架默认值），并以诊断指明写法约束
mth.HasTimeout = false;
var rawArgument = attribute.ArgumentList != null && attribute.ArgumentList.Arguments.Count > 0
? attribute.ArgumentList.Arguments[0].ToString()
: string.Empty;
diagnostics.Add(Logger.Error($"{fullName}.{method.Identifier.Text}【{TimeOutAttributeName}】参数必须是整数字面量（毫秒），当前无法解析：{rawArgument}", method.GetLocation()));
}
ApplyTimeoutAttribute(diagnostics, fullName, method, attribute, mth);
}
else if (string.Equals(name, StripAttributeSuffix(ThreadSafeAttributeName), StringComparison.OrdinalIgnoreCase))
{
Expand All @@ -455,6 +442,35 @@ private static void ApplyAttribute(List<Diagnostic> diagnostics, string fullName
}
}

/// <summary>
/// 应用命中的 TimeOut 特性：解析成功置超时标记，失败降级为未配置并以 Error 诊断指明写法约束。
/// </summary>
/// <remarks>
/// Applies the matched TimeOut attribute: a successfully parsed literal sets the timeout flag;
/// otherwise it degrades to "not configured" and emits an Error diagnostic stating the expected literal form.
/// </remarks>
/// <param name="diagnostics">诊断缓冲 / Diagnostics buffer</param>
/// <param name="fullName">代理类完全限定名 / Fully qualified name of the agent class</param>
/// <param name="method">方法声明语法节点 / Method declaration syntax node</param>
/// <param name="attribute">命中的 TimeOut 特性语法节点 / The matched TimeOut attribute syntax node</param>
/// <param name="mth">待填充的方法元数据 / Method metadata to populate</param>
private static void ApplyTimeoutAttribute(List<Diagnostic> diagnostics, string fullName, MethodDeclarationSyntax method, AttributeSyntax attribute, MethodInfoData mth)
{
mth.TimeOut = ParseTimeout(attribute, out var parsed);
if (parsed)
{
mth.HasTimeout = true;
return;
}

// 解析失败降级为未配置超时（走 EnqueueAsync 框架默认值），并以诊断指明写法约束
mth.HasTimeout = false;
var rawArgument = attribute.ArgumentList != null && attribute.ArgumentList.Arguments.Count > 0
? attribute.ArgumentList.Arguments[0].ToString()
: string.Empty;
diagnostics.Add(Logger.Error($"{fullName}.{method.Identifier.Text}【{TimeOutAttributeName}】参数必须是整数字面量（毫秒），当前无法解析：{rawArgument}", method.GetLocation()));
}

/// <summary>
/// 剥离特性名尾部的 Attribute 后缀（[Service] 与 [ServiceAttribute] 书写等价）。
/// </summary>
Expand Down
Loading