Skip to content

fix(online): 补齐 Game Role 存储配置缺失的无声降级防护 - #641

Merged
AlianBlank merged 1 commit into
mainfrom
feature/auto-server-source-worker-run-11939-20261025T0610
Oct 26, 2026
Merged

AlianBlank merged 1 commit into
mainfrom
feature/auto-server-source-worker-run-11939-20261025T0610

Conversation

@AlianBlank

Copy link
Copy Markdown
Collaborator

Fixes GFX-1015
Closes #639

Game Role 启用 Online 能力族但未声明 UseGameDbStores 时缺省走
InMemory,重启即失玩家身份/好友/资产/存储数据且无任何告警。
现将该开关三态化并在组合根对未声明形态发出启动期 Warning,
同时为 Game Role 配置显式声明落库;不 fail-fast 以保护既有无键部署。

BREAKING CHANGE: OnlineCapabilityOptions.UseGameDbStores 由 bool 改三态 bool?(null=未声明、true=落库、false=显式易失),消费方需按可空布尔判读。

Closes #639

Linear: GFX-1015
@linear-code

linear-code Bot commented Oct 25, 2026

Copy link
Copy Markdown

GFX-1015

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ecd83d54-1ef2-4ea5-9f31-bd984a56db4f
Commits

Reviewing files that changed from the base of the PR and between 939ec07 and 637efd0.

Files selected for processing: 9
  • CHANGELOG.md
  • Configs/app_config.json
  • GameFrameX.Launcher/Online/OnlineCapabilityCompositionRoot.cs
  • GameFrameX.Localization/Keys.Capability.cs
  • GameFrameX.Localization/Localization/Messages/Resources.resx
  • GameFrameX.Localization/Localization/Messages/Resources.zh-CN.resx
  • GameFrameX.Utility/Setting/OnlineCapabilityOptions.cs
  • Tests/GameFrameX.Tests/Online/OnlineCapabilityStoreModeWarningTests.cs
  • Tests/GameFrameX.Tests/Utility/OnlineCapabilityConfigSectionTests.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@AlianBlank
AlianBlank merged commit ab23b3e into main Oct 26, 2026
3 checks passed
@AlianBlank
AlianBlank deleted the feature/auto-server-source-worker-run-11939-20261025T0610 branch October 26, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

补齐 Game Role Online 存储配置缺失导致的无声 InMemory 降级

1 participant