Skip to content

P1 [Sonar] Fix GameFrameX.Core/BaseHandler/RPC/BaseRpcComponentHandler.cs (1 issue) #956

Closed

Description

@github-actions

This GitHub Issue groups current SonarQube Cloud findings for one file so the file can be fixed in a single pass.

Project: GameFrameX.Server.Source
Branch: main
File: GameFrameX.Core/BaseHandler/RPC/BaseRpcComponentHandler.cs
Group: file
Count: 1
Severities: CRITICAL
Types: CODE_SMELL
Rules: csharpsquid:S3776

Findings:

  • AaGXFG6oeoeKgQYqeRni - CRITICAL/CODE_SMELL - csharpsquid:S3776 - GameFrameX.Core/BaseHandler/RPC/BaseRpcComponentHandler.cs:145 - Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed.

Acceptance:

  • Fix all listed current Sonar findings in this file.
  • Keep the existing public API unchanged unless the finding requires a contract change.
  • Rerun the repository quality workflow and verify Sonar no longer reports these keys.

Activity

  1. linear-code commented on Nov 1, 2026

    @linear-code
  2. AlianBlank commented on Nov 1, 2026

    @AlianBlank
    Collaborator

    与 #944 为同一 Sonar 发现项(key AaGXFG6oeoeKgQYqeRni),已由 PR #954 修复(ExecuteWorkAsync 抽取 WriteTimeoutResponseAsync / ReturnResponseAtTerminalState)并合入 main,重复关闭。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions