SphereLevelSet : Add more efficient overrides for hash/computeBound()#6537
Merged
Conversation
Contributor
|
LGTM |
This fixes `SphereLevelSetTest.testBounds` which I broke when I merged e6cbd98. That exposed a bug in `VDBObject::bound()` whereby it relied on metadata to provide the bound, when in fact the metadata is entirely optional. The VDBObject bug hasn't been a problem for any of our other VDB nodes because they compute Gaffer bounds efficiently rather than making them depend on the voxel grid. While we do have a fix for the VDBObject bug (see ImageEngine/cortex#1423), it seems worthwhile to have a more efficient implementation for SphereLevelSet anyway.
johnhaddon
force-pushed
the
sphereLevelSetFix
branch
from
6bc1362 to
3d2a727
Compare
github-project-automation
Bot
moved this from Pending Review
to Pending release
in Work in Progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
SphereLevelSetTest.testBoundswhich I broke when I merged e6cbd98. That exposed a bug inVDBObject::bound()whereby it relied on metadata to provide the bound, when in fact the metadata is entirely optional. The VDBObject bug hasn't been a problem for any of our other VDB nodes because they compute Gaffer bounds efficiently rather than making them depend on the voxel grid. While we do have a fix for the VDBObject bug (see ImageEngine/cortex#1423), it seems worthwhile to have a more efficient implementation for SphereLevelSet anyway.