Cycles : Generate tangent patch fix to avoid a crash.#300
Merged
Conversation
4 tasks
Contributor
Author
|
https://projects.blender.org/blender/blender/pulls/158107 keeping a record of the PR I've put up for Blender to merge into future versions. |
murraystevenson
approved these changes
May 4, 2026
Contributor
murraystevenson
left a comment
murraystevenson
left a comment
There was a problem hiding this comment.
Thanks @boberfly, this does avoid the crash on my end and it looks like your Blender PR has been approved, so we'll be able to drop this patch on the next Cycles update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch I will upstream to Blender's main repository. They avoid this crash as the generated attribute aka "Pref" is always generated Blender-side and handed off instead of Cycles creating its own.
The issue was that the generated attribute was made after tessellation and only filled this attribute to the size of the original un-diced mesh. The patch ensures the attribute is created before tessellation and will interpolate after.
The crash was discovered by @murraystevenson here: GafferHQ/gaffer#6885