Post commands copy / move files#297
Open
ericmehl wants to merge 11 commits into
Open
Conversation
This optional configuration item will move a given set of files after the `commands` step. It is useful for unifying the Linux and Windows configurations, particularly when it comes to moving directories and creating destination directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two new configuration operations : one to copy files after the build commands have run, and a companion operation for moving. This is mostly a precursor to introducing more Windows support in the main branch. It will be helpful for resolving differences between copy commands on the different platforms.
I'm hoping the way I've parameterized it is clear enough. I'm mimicking
os.glob()an introducing a source root to go along with the search pattern. This makes it possible to control where a directory sub-tree should go for both relative and absolute paths.I checked on a local build that all the same files end up in the archive as the past release and found a couple Qt header files were missing but I'm hoping those are false positives. They seem unrelated to the changes in this PR.