Do not advertize fortran order for cubical#77
Merged
VincentRouvreau merged 1 commit intoGUDHI:masterfrom Dec 20, 2024
Merged
Conversation
…ated for seaborn 0.14, use fill=True instead
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mglisse
approved these changes
Dec 20, 2024
Member
mglisse
left a comment
mglisse
left a comment
There was a problem hiding this comment.
ok. Ideally we would use non-square matrices so we can plot and check if it looks ok, but that's less important.
VincentRouvreau
deleted the
do_not_advertize_fortran_order_for_cubical
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help users for issues like GUDHI/gudhi-devel#1162
Also minor change:
shade=Truewill be deprecated for seaborn 0.14, usefill=Trueinstead