Skip to content

Add world conversion warning screen - #210

Merged
FourIsTheNumber merged 13 commits into
masterfrom
wc-gui
Jul 25, 2026
Merged

Add world conversion warning screen#210
FourIsTheNumber merged 13 commits into
masterfrom
wc-gui

Conversation

@SuperSoupr

@SuperSoupr SuperSoupr commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Adds 2 warnings
for when world conversion is about to happen
and for when exu isn't loaded but also world conversion is disabled

image

# Conflicts:
#	dependencies.gradle
#	src/main/java/com/fouristhenumber/utilitiesinexcess/UtilitiesInExcess.java
#	src/main/resources/assets/utilitiesinexcess/lang/en_US.lang
@SuperSoupr

Copy link
Copy Markdown
Contributor Author

Activation logic for this needs to be discussed, not sure what was decided in the end
Are we having a warning all the time or just when not in nh?

@FourIsTheNumber

Copy link
Copy Markdown
Collaborator

Activation logic for this needs to be discussed, not sure what was decided in the end Are we having a warning all the time or just when not in nh?

Probably best to ask admins or poll in dev votes

@boubou19

boubou19 commented Jul 5, 2026

Copy link
Copy Markdown
Member

If we look into what NH does already, you'll see that we only expose a warning when there are unhandled missing mapping events fired. FPLib added another message when the id extenders have changed, copying the fml missing mapping screen. But if your goal is to do a seamless transition on NH, the screen should not be visible imo.

Also, no matter what you end up chosing, i suggest to make it so that screen behaves the same as regular forge screen, so server admins can control it with -Dfml.doNotBackup and -Dfml.queryResult flags.

@FourIsTheNumber

Copy link
Copy Markdown
Collaborator

I think disabling it in nh is likely fine, but we can config it on by default.

@SuperSoupr

SuperSoupr commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Yeah, I agree with disabling it in nh but keeping the default on

i suggest to make it so that screen behaves the same as regular forge screen, so server admins can control it with -Dfml.doNotBackup and -Dfml.queryResult flags.

It piggybacks off of the fml query system so those flags will already work for it too :)

FourIsTheNumber and others added 4 commits July 5, 2026 21:22
# Conflicts:
#	src/main/java/com/fouristhenumber/utilitiesinexcess/CommonProxy.java
#	src/main/java/com/fouristhenumber/utilitiesinexcess/UtilitiesInExcess.java
#	src/main/resources/assets/utilitiesinexcess/lang/en_US.lang
Comment thread src/main/resources/assets/utilitiesinexcess/lang/en_US.lang Outdated
Comment thread src/main/resources/assets/utilitiesinexcess/lang/en_US.lang Outdated
@FourIsTheNumber
FourIsTheNumber enabled auto-merge (squash) July 25, 2026 18:25
@FourIsTheNumber
FourIsTheNumber merged commit 1171cb4 into master Jul 25, 2026
1 check passed
@FourIsTheNumber
FourIsTheNumber deleted the wc-gui branch July 25, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants