You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm still quite unsure if this is the right solution, since this seems to make the code be dependent on data card to decode nbt
There's also a way by flatting the stack into the event arguments but that'll also lead to omitting some details of the item stack
So it's one way or another
I'm still quite unsure if this is the right solution, since this seems to make the code be dependent on data card to decode nbt There's also a way by flatting the stack into the event arguments but that'll also lead to omitting some details of the item stack So it's one way or another
Why would it depend on the data card? I don't think NBTTagCompound compresses itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug FixFixes a bug. Please link it in the PR if an issue exists for it.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the console warnings by serializing stacks to NBTTagCompound to satisfy signal constraints.
fixes GTNewHorizons/GT-New-Horizons-Modpack#26028
Checklist