Skip to content

fix(appeng): serialize stack to NBTTagCompound to satisfy signal constraints - #213

Merged
Dream-Master merged 3 commits into
GTNewHorizons:masterfrom
hinyb:fix/appeng-subscription
Aug 25, 2026
Merged

fix(appeng): serialize stack to NBTTagCompound to satisfy signal constraints#213
Dream-Master merged 3 commits into
GTNewHorizons:masterfrom
hinyb:fix/appeng-subscription

Conversation

@hinyb

@hinyb hinyb commented Jul 27, 2026

Copy link
Copy Markdown

Summary

This PR resolves the console warnings by serializing stacks to NBTTagCompound to satisfy signal constraints.
fixes GTNewHorizons/GT-New-Horizons-Modpack#26028

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy
  • This PR requires another PR in order to merge

@hinyb hinyb added the Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. label Jul 27, 2026
@Azusfin

Azusfin commented Aug 24, 2026

Copy link
Copy Markdown

I'm still quite unsure if this is the right solution, since this seems to make the code be dependent on data card to decode nbt
There's also a way by flatting the stack into the event arguments but that'll also lead to omitting some details of the item stack
So it's one way or another

@hinyb

hinyb commented Aug 24, 2026

Copy link
Copy Markdown
Author

I'm still quite unsure if this is the right solution, since this seems to make the code be dependent on data card to decode nbt There's also a way by flatting the stack into the event arguments but that'll also lead to omitting some details of the item stack So it's one way or another

Why would it depend on the data card? I don't think NBTTagCompound compresses itself.

@Azusfin

Azusfin commented Aug 24, 2026

Copy link
Copy Markdown

ah wait, did i misunderstand what this is supposed to change

@hinyb

hinyb commented Aug 24, 2026

Copy link
Copy Markdown
Author

ah wait, did i misunderstand what this is supposed to change

No worries! I made this change simply because the signal needs to be serialized to disk, so I'm using NBTTagCompound just like ItemStack does.

@Azusfin Azusfin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dream-Master
Dream-Master enabled auto-merge (squash) August 25, 2026 04:29
@Dream-Master
Dream-Master merged commit 2c00f79 into GTNewHorizons:master Aug 25, 2026
1 check passed
@hinyb
hinyb deleted the fix/appeng-subscription branch August 26, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenComputers: using me_interface.setItemEventSubscription generates warnings in GTNH server output

3 participants