Fix kitchen door hinges ending up on the wrong side - #66
Open
JustRomanBZK wants to merge 1 commit into
Open
Conversation
JustRomanBZK
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There were 2 problems.
Because of this, after negative yaw accumulates:
CLIENT yaw=-1842.449 bR=-19.971654891967773 flipped=false orientation=0
SERVER yaw=-42.599 bR=0.02667778730392456 flipped=true orientation=0
Client and server mismatched on which side to draw the hinge on.
Because of that, for 1 tick we saw the block being placed correctly.
Fix: use floor_double instead of int/abs.
After the fix:
CLIENT yaw=-2499.151 bR=-27.268342971801758 flipped=false orientation=0
SERVER yaw=-339.30078 bR=-3.2700085639953613 flipped=false orientation=0
Checklist