fix(rule): catch unsafe boolean guards - #81
Merged
Conversation
Resolve initializer evidence from its lexical scope and reject ambiguous var redeclarations. Treat direct Boolean writes as unsafe and use a mutation-proof fallback fix.
|
馃帀 Congratulations on making your first pull request in '@gstj/safe-jsx'! We appreciate your contribution and will review it as soon as possible. Thank you for helping us make this project better. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
The rule now catches JSX guards that rely on a redeclared variable, the wrong initializer scope, or a replaced
Boolean.Details
varredeclarations and every write after the trusted initializer.Booleanas unsafe, with!!as the autofix fallback.Testing steps
pnpm install --frozen-lockfile pnpm run test --runInBand