Dispatch the combobox input event so onInput works

[arpitjain099]

Fixes #659.

_initEventDispatcher registers "input" and onInput() subscribes to it, but _setupInputEvents only dispatched "search", so a callback passed to onInput() was never called. Nothing surfaced it either: EventDispatcher.on accepts the registration because the event name is a valid one, and only throws for names it does not know.

Of the two options in the issue I took dispatching over removing. Nothing in this repository calls onInput() today (picker.ts uses onSearch), so removal would compile cleanly here, but it would break any consumer outside the repo that is already subscribing and would turn a dormant bug into a build failure for them. Dispatching keeps the declared API and makes it do what its name says.

Testing

abstract-combobox.spec.ts is new; the class had no spec before. Three cases: the onInput callback fires, the onSearch callback still fires, and both receive the same input event in order.

Against master:

× should call an onInput callback when the input changes
  → expected +0 to be 1
× should pass the input event through to both callbacks
  → expected [ 'search:input' ] to deeply equal [ 'input:input', 'search:input' ]
Tests  2 failed | 1 passed (3)

With the change, 3 passed. The onSearch case passes either way on purpose, since the point of the change is that it must keep working.

prettier --check is clean on the directory.

One caveat on the full suite: running all of test-app's vitest here fails to transform 33 spec files on missing peer packages (@fortawesome/free-solid-svg-icons and similar), before and after this change alike, so I ran the combobox spec on its own rather than quote a suite number I could not attribute.

[Copilot]

Pull request overview

Fixes the combobox’s dormant onInput() API while preserving existing search behavior.

Changes:

• Dispatches the native input event to both input and search subscribers.
• Adds focused regression and compatibility tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
abstract-combobox.ts	Dispatches the registered "input" event.
abstract-combobox.spec.ts	Tests input callbacks, search callbacks, and dispatch order.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mgetzflex]

@arpitjain099 FYI as this repository is a work of the US government it contains large parts of the code that are public domain. Are you willing to assign your code as such to keep the licensing simple for other users?

[fpigeonjr]

Thank you for this contribution, @arpitjain099 — genuinely appreciated. Your diagnosis here was exactly right: _initEventDispatcher registered "input" and onInput() accepted subscribers, but _setupInputEvents only ever dispatched "search", so those callbacks were dead. Your reasoning for dispatching rather than removing onInput() — that removal compiles fine in-repo but turns a dormant bug into a build break for outside consumers — is the call we went with too.

Closing as superseded: the same fix landed on master in #672 (f6e7223), and issue #659 is closed as completed. master now dispatches "input" alongside "search" from the same native listener, with a regression spec in abstract-combobox.spec.ts.

The only reason this isn't a straight merge is branch age — this was cut from a much older master, so git diff origin/master on it shows ~89 files / ~6,500 deletions, reverting the #650–#660 spec work, the tabs CSS fix (#668), the Playwright gallery harness (#665), and the coverage-floor gate (#670, #673). A rebase would leave an empty diff.

None of that reflects on the work — the analysis stood up and the outcome on master matches what you proposed. Please do keep the bug reports and fixes coming.