Skip to content

Fix error message being hidden if GFF3 export fails - #875

Merged
garrettjstevens merged 1 commit into
GMOD:mainfrom
YashAnand69:fix/export-error-dialog-oct30
Oct 30, 2026
Merged

garrettjstevens merged 1 commit into
GMOD:mainfrom
YashAnand69:fix/export-error-dialog-oct30

Conversation

@YashAnand69

Copy link
Copy Markdown
Contributor

An unsuccessful export-ID request sets an error message, then returns normally and lets the form close the dialog. Keep failures in the form's error path so the message stays visible and Download can be retried. Close the dialog after a successful export.

Fixes #874.

Validation:

  • Actual Chrome/JBrowse/Apollo flow on Linux: all three export tests pass, including error → visible message → retry. On unchanged main, the new case fails because the dialog disappears; the existing FASTA and GFF-only downloads both pass. The new case intercepts only the export-ID response and stubs the retry's new window; the existing cases download and check actual files. Browser validation.
  • 54 local plugin unit tests and 11 snapshots pass; plugin TypeScript, changed-file ESLint, formatting and normal commit hooks pass.
  • The upstream strict lint and configuration type-check jobs pass on Ubuntu. Lint validation. Full repository lint locally reports identical type-resolution errors on untouched main and this patch; no suppression or unrelated fixes are included.

The temporary validation workflows remain on fork-only branches. The current #863 and #839 versions retain this same error/close behavior; this patch changes neither their account/assembly architecture nor the export format.

AI assistance: OpenAI Codex investigated, implemented, tested and reviewed this change.

@garrettjstevens garrettjstevens changed the title Keep annotation export errors visible for retry Fix error message being hidden if GFF3 export fails Oct 30, 2026
@garrettjstevens
garrettjstevens merged commit bb1f23f into GMOD:main Oct 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annotation export dialog closes before displaying request errors

2 participants