Repository navigation
Show gene background colors in six-frame display - #870
Conversation
Assisted-by: Codex:GPT-6
Preserve the renderer and geometry changes from GMOD#871 while retaining configured gene backgrounds. Exercise the current glyph entry point and real geometry helpers in both block orientations. Assisted-by: Codex:GPT-6
|
Merged current main in Updated the glyph regression to use the new draw signature and real geometry helpers in forward and reversed blocks. On current main, the three configured-color cases fail while fallback/selection controls pass. With the fix, all 60 plugin tests and 11 snapshots pass; plugin/Node type checks, changed-file lint and formatting pass. Rebuilt JBrowse browser checks against current-main and updated bundles confirm the ordinary-gene fallback, special/custom colors and selection behavior without page errors. That browser fixture covers one region; it is not a claim of a fresh full multi-region Cypress run. Codex (GPT-6) assisted with the merge, test adaptation and validation; an independent agent reviewed the final diff. |
Use the captured Linux comparison after independent review of the intended background difference. Keep the image threshold unchanged. The same targeted Linux Cypress suite passes with this baseline. Assisted-by: Codex:GPT-6
|
The new-head Cypress failure was the multi-region six-frame snapshot added in #871. I reproduced it on the fork's Linux runner and inspected the captured baseline/comparison/diff with an independent review. Of 858 flagged pixels, 831 are the intended pseudogene background change; the remaining 27 are sparse text-edge antialias differences. The four other snapshots pass. Updated only that baseline from the actual Linux capture. The threshold remains Codex (GPT-6) assisted with the diagnosis, independent image review and baseline update. |
Assisted-by: Codex:GPT-6
Fixes #694.
The six-frame display always painted a gene's central background with the theme paper color, so pseudogenes, ncRNA genes and custom
geneBackgroundColorsettings were ignored. Read the existing Apollo plugin configuration with the feature type, as the standard annotation display does. Keep the existing paper fallback, selected-gene black highlight, strand patterns and geometry. No new configuration or hardcoded gene palette.Validation:
Before (ordinary gene, pseudogene, ncRNA gene from left to right):
After:
The demo uses a minimal local annotation fixture; its orange validation icons are unrelated fixture warnings. Existing six-frame opacity/stripe compositing is retained, so this does not claim pixel-identical rendering to the standard display. Selection, custom-color evidence and pixel results. Proof assets are on a separate fork branch, outside this source patch.
Codex (GPT-6) assisted with investigation, implementation, tests and validation.