Merged
Conversation
mlemayTTE
changed the title
mlemayTTE
changed the title
paloma-martinez
approved these changes
May 5, 2025
Collaborator
paloma-martinez
left a comment
paloma-martinez
left a comment
There was a problem hiding this comment.
Thank you for this work, it will be very useful.
I made a lots of suggestions, but they are basically all the same, just formatting.
alexbenedicto
requested changes
May 8, 2025
Comment on lines
+11
to
+15
| geos_pv_path: Path = Path( __file__ ).parent.parent | ||
| sys.path.insert( 0, str( geos_pv_path / "src" ) ) | ||
| from geos.pv.utils.config import update_paths | ||
|
|
||
| update_paths() |
Comment on lines
+11
to
+16
| # update sys.path to load all GEOS Python Package dependencies | ||
| geos_pv_path: Path = Path( __file__ ).parent.parent | ||
| sys.path.insert( 0, str( geos_pv_path / "src" ) ) | ||
| from geos.pv.utils.config import update_paths | ||
|
|
||
| update_paths() |
Collaborator
There was a problem hiding this comment.
Same remark for paths
Comment on lines
+11
to
+15
| geos_pv_path: Path = Path( __file__ ).parent.parent | ||
| sys.path.insert( 0, str( geos_pv_path / "src" ) ) | ||
| from geos.pv.utils.config import update_paths | ||
|
|
||
| update_paths() |
Collaborator
There was a problem hiding this comment.
Same remark for paths
Comment on lines
+22
to
+27
| # update sys.path to load all GEOS Python Package dependencies | ||
| geos_pv_path: Path = Path( __file__ ).parent.parent | ||
| sys.path.insert( 0, str( geos_pv_path / "src" ) ) | ||
| from geos.pv.utils.config import update_paths | ||
|
|
||
| update_paths() |
Collaborator
There was a problem hiding this comment.
Same remark for paths
Comment on lines
31
to
34
| __doc__ = """ | ||
| Example of a Paraview plugin that runs through time steps. | ||
|
|
||
| """ |
Collaborator
There was a problem hiding this comment.
Documentation does not explain what "running through time steps" means
| panel_visibility="default"> | ||
| <Property name="BoolSingle"/> | ||
| </PropertyGroup>""" ) | ||
| def c03BoolInputsGroup( self: Self ) -> None: |
Collaborator
There was a problem hiding this comment.
Should be c05BoolInputsGroup
alexbenedicto
approved these changes
May 14, 2025
av-novikov
pushed a commit
that referenced
this pull request
May 19, 2025
* Add Paraview Proxy examples * linting, formating, typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds examples of Paraview plugins.