fix: collocated_nodes array name to match GEOS name#170
Merged
alexbenedicto merged 1 commit intomainfrom Nov 10, 2025
Merged
Conversation
alexbenedicto
added
flag: ready for review
type: bug
test-geos-integration
alexbenedicto
changed the title
bd713
approved these changes
Nov 8, 2025
alexbenedicto
deleted the
benedicto/fix/collocated_nodes_name_generateFractures
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a split mesh using generateFractures, two meshes are created:
The fracture meshes receive a new property called "collocated_nodes", which name is hardcoded in CollocatedNodes.cpp.
Following the work done in #146 to update mesh-doctor to camelCase, the name was incorrectly changed to "collocatedNodes" which was a mistake and was noticed thanks to @bd713 and @jhuang2601 .
This PR aims to revert this change to keep the correct "collocated_nodes" name.